[Ash] Remove |highlight| field from NetworkInfo struct

ash/system/network/network_list.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/network/network_list.h"
 
 #include <stddef.h>
 
 #include "ash/strings/grit/ash_strings.h"
 #include "ash/system/network/network_icon.h"
@@ skipping 353 matching lines @@
       const int order1 =
           GetOrder(handler_->GetNetworkStateFromGuid(network1->guid));
       const int order2 =
           GetOrder(handler_->GetNetworkStateFromGuid(network2->guid));
       if (order1 != order2)
         return order1 < order2;
       if (network1->connected != network2->connected)
         return network1->connected;
       if (network1->connecting != network2->connecting)
         return network1->connecting;
-      if (network1->highlight != network2->highlight)

[tdanderson, 2017/04/19 20:45:59]

note: this is not just lazily deleting code; based on lines 422, 370, and 372, I
think that line 375 was never actually reachable anyway.

-        return network1->highlight;
       return network1->guid.compare(network2->guid) < 0;
     }
 
    private:
     static int GetOrder(const chromeos::NetworkState* network) {
       if (!network)
         return 999;
       if (network->Matches(NetworkTypePattern::Ethernet()))
         return 0;
       if (network->Matches(NetworkTypePattern::Cellular()))
@@ skipping 26 matching lines @@
     bool prohibited_by_policy = IsProhibitedByPolicy(network);
     info->label = network_icon::GetLabelForNetwork(
         network, network_icon::ICON_TYPE_MENU_LIST);
     info->image =
         network_icon::GetImageForNetwork(network, network_icon::ICON_TYPE_LIST);
     info->disable =
         (network->activation_state() == shill::kActivationStateActivating) ||
         prohibited_by_policy;
     info->connected = network->IsConnectedState();
     info->connecting = network->IsConnectingState();
-    info->highlight = info->connected || info->connecting;
     if (network->Matches(NetworkTypePattern::WiFi()))
       info->type = NetworkInfo::Type::WIFI;
     else if (network->Matches(NetworkTypePattern::Cellular()))
       info->type = NetworkInfo::Type::CELLULAR;
     else if (network->Matches(NetworkTypePattern::Tether()))
       info->type = NetworkInfo::Type::TETHER;
     if (prohibited_by_policy) {
       info->tooltip =
           l10n_util::GetStringUTF16(IDS_ASH_STATUS_TRAY_NETWORK_PROHIBITED);
     }
@@ skipping 241 matching lines @@
   if (found == last_network_info_map_.end()) {
     // If we cannot find |info| in |last_network_info_map_|, just return true
     // since this is a new network so we have nothing to compare.
     return true;
   } else {
     return *found->second != info;
   }
 }
 
 }  // namespace ash