Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ash/system/network/network_list.cc

Issue 2828893002: [Ash] Remove |highlight| field from NetworkInfo struct (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/network/network_info.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/network/network_list.cc
diff --git a/ash/system/network/network_list.cc b/ash/system/network/network_list.cc
index cdb1001dda89086349b7613b55b97bd3e73491f1..9e308afc12264bf050d8c7d8a8f436610bc06f2a 100644
--- a/ash/system/network/network_list.cc
+++ b/ash/system/network/network_list.cc
@@ -371,8 +371,6 @@ void NetworkListView::OrderNetworks() {
return network1->connected;
if (network1->connecting != network2->connecting)
return network1->connecting;
- if (network1->highlight != network2->highlight)
tdanderson 2017/04/19 20:45:59 note: this is not just lazily deleting code; based
- return network1->highlight;
return network1->guid.compare(network2->guid) < 0;
}
@@ -419,7 +417,6 @@ void NetworkListView::UpdateNetworkIcons() {
prohibited_by_policy;
info->connected = network->IsConnectedState();
info->connecting = network->IsConnectingState();
- info->highlight = info->connected || info->connecting;
if (network->Matches(NetworkTypePattern::WiFi()))
info->type = NetworkInfo::Type::WIFI;
else if (network->Matches(NetworkTypePattern::Cellular()))
« no previous file with comments | « ash/system/network/network_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698