Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 2828553002: Search correctly for inline ancestors without a sibling when dirtying lineboxes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by rhogan
Modified:
6 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Search correctly for inline ancestors without a sibling when dirtying lineboxes Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have checked whether the current child has a previous sibling, not the candidate parent. Also revert to the original version of the two tests - as the new versions never fail. BUG=695378 Review-Url: https://codereview.chromium.org/2828553002 Cr-Commit-Position: refs/heads/master@{#465686} Committed: https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a57c882195f86

Patch Set 1 #

Total comments: 2

Patch Set 2 : bug 695378 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-expected.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 1 1 chunk +11 lines, -9 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (10 generated)
rhogan
6 months ago (2017-04-18 21:09:49 UTC) #7
mstensho (USE GERRIT)
lgtm with nits. https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp File third_party/WebKit/Source/core/layout/line/LineBoxList.cpp (right): https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp#newcode296 third_party/WebKit/Source/core/layout/line/LineBoxList.cpp:296: LineLayoutItem parent = child.Parent(); |parent| is ...
6 months ago (2017-04-19 11:37:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828553002/20001
6 months ago (2017-04-19 17:14:59 UTC) #11
commit-bot: I haz the power
6 months ago (2017-04-19 19:01:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa