Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(107)

Issue 2828553002: Search correctly for inline ancestors without a sibling when dirtying lineboxes (Closed)

Created:
1 year, 1 month ago by rhogan
Modified:
1 year, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Search correctly for inline ancestors without a sibling when dirtying lineboxes Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have checked whether the current child has a previous sibling, not the candidate parent. Also revert to the original version of the two tests - as the new versions never fail. BUG=695378 Review-Url: https://codereview.chromium.org/2828553002 Cr-Commit-Position: refs/heads/master@{#465686} Committed: https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a57c882195f86

Patch Set 1 #

Total comments: 2

Patch Set 2 : bug 695378 #

Messages

Total messages: 14 (10 generated)
rhogan
1 year, 1 month ago (2017-04-18 21:09:49 UTC) #7
mstensho (USE GERRIT)
lgtm with nits. https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp File third_party/WebKit/Source/core/layout/line/LineBoxList.cpp (right): https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/core/layout/line/LineBoxList.cpp#newcode296 third_party/WebKit/Source/core/layout/line/LineBoxList.cpp:296: LineLayoutItem parent = child.Parent(); |parent| is ...
1 year, 1 month ago (2017-04-19 11:37:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828553002/20001
1 year, 1 month ago (2017-04-19 17:14:59 UTC) #11
commit-bot: I haz the power
1 year, 1 month ago (2017-04-19 19:01:06 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a...

Powered by Google App Engine
This is Rietveld 408576698