Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2486423003: Dirty lineboxes when adding floats to a nested empty inline (Closed)

Created:
4 years, 1 month ago by rhogan
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Dirty lineboxes when adding floats to a nested empty inline A follow-on from https://codereview.chromium.org/2411773003 BUG=648342 Committed: https://crrev.com/43c0e7342917bc85ee65fe05e7b4e39e6e485362 Cr-Commit-Position: refs/heads/master@{#431521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2.html View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/block/float/float-should-dirty-line-when-adjacent-to-line-breaks-2-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/LineBoxList.cpp View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rhogan
4 years, 1 month ago (2016-11-10 21:54:52 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-11-10 23:34:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486423003/1
4 years, 1 month ago (2016-11-11 00:03:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/329951)
4 years, 1 month ago (2016-11-11 05:22:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2486423003/1
4 years, 1 month ago (2016-11-11 06:40:04 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-11 08:01:38 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-11 08:09:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43c0e7342917bc85ee65fe05e7b4e39e6e485362
Cr-Commit-Position: refs/heads/master@{#431521}

Powered by Google App Engine
This is Rietveld 408576698