Search correctly for inline ancestors without a sibling when dirtying lineboxes

Search correctly for inline ancestors without a sibling when dirtying lineboxes

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG=695378
Review-Url: https://codereview.chromium.org/2828553002
Cr-Commit-Position: refs/heads/master@{#465686}
Committed: https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a57c882195f86

[rhogan, 2017-04-18 18:35:02]

Description was changed from

==========
Search correctly for inline ancestors without a sibling when dirtying lineboxes

BUG=695378
==========

to

==========
Search correctly for inline ancestors without a sibling when dirtying lineboxes

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate
parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG=695378
==========

[rhogan, 2017-04-18 18:35:08]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:35:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 20:19:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:19:24]

Dry run: This issue passed the CQ dry run.

[rhogan, 2017-04-18 21:09:48]

robhogan@gmail.com changed reviewers:
+ mstensho@opera.com

[mstensho (USE GERRIT), 2017-04-19 11:37:24]

lgtm with nits.

https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/LineBoxList.cpp (right):

https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/LineBoxList.cpp:296: LineLayoutItem
parent = child.Parent();
|parent| is only needed if child.IsFloating(), so I think it would be better to
move it inside some scope (not that it's so much cheaper, but it makes it easier
to read). Something like this:

if (child.IsFloating() && !curr)  {
  LineLayoutItem parent = child.Parent();
  if (parent && parent.IsLayoutInline()) {
     outer_inline = parent;
     while ...
     if (outer_inline) ...
  }
}

... or just omit the declaration of |parent| completely. Writing
"child.Parent()" a couple of times extra doesn't sound so harmful. Do we really
need the parent NULL-check, BTW? I think I'd like the program to just go ahead
and die of the child doesn't have a parent. :)

https://codereview.chromium.org/2828553002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/LineBoxList.cpp:300:
!outer_inline.PreviousSibling())
Could you check !outer_inline.PreviousSibling() BEFORE
outer_inline.Parent().IsLayoutInline()? I had a hard time reading this, and
besides it doesn't matter what the parent is if outer_inline has siblings.

[rhogan, 2017-04-19 17:14:24]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2017-04-19 17:14:24]

The patchset sent to the CQ was uploaded after l-g-t-m from mstensho@opera.com
Link to the patchset: https://codereview.chromium.org/2828553002/#ps20001
(title: "bug 695378")

[commit-bot: I haz the power, 2017-04-19 17:14:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 19:00:33]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492622064344960,
"parent_rev": "a5a9fddc48214cb8114e39fe1659e130a178cc3a", "commit_rev":
"c7a0755ef5b59863b714ceaa988a57c882195f86"}

[commit-bot: I haz the power, 2017-04-19 19:01:05]

Description was changed from

==========
Search correctly for inline ancestors without a sibling when dirtying lineboxes

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate
parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG=695378
==========

to

==========
Search correctly for inline ancestors without a sibling when dirtying lineboxes

Fixes a mistake in https://codereview.chromium.org/2486423003 - it should have
checked whether the current child has a previous sibling, not the candidate
parent.

Also revert to the original version of the two tests - as the new versions never
fail.

BUG=695378

Review-Url: https://codereview.chromium.org/2828553002
Cr-Commit-Position: refs/heads/master@{#465686}
Committed:
https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a...
==========

[commit-bot: I haz the power, 2017-04-19 19:01:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c7a0755ef5b59863b714ceaa988a...