Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2820263005: In QUIC version >= 38, enables random padding of size [1, 256] (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

In QUIC version >= 38, enables random padding of size [1, 256] Protected by FLAGS_quic_reloadable_flag_quic_enable_random_padding. Merge internal change: 153198827

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -193 lines) Patch
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_connection.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/core/quic_connection_test.cc View 96 chunks +146 lines, -150 lines 0 comments Download
M net/quic/core/quic_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/core/quic_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/core/quic_session_test.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M net/quic/core/quic_stream.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/quic/core/quic_stream.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M net/quic/core/quic_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quartc/quartc_stream_test.cc View 1 chunk +1 line, -1 line 2 comments Download
M net/quic/test_tools/quic_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/simulator/quic_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2820413002 Patch 1

Dependent Patchsets:

Issue 2827503003 Patch 1

Messages

Total messages: 5 (1 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-18 19:02:28 UTC) #2
Zhongyi Shi
https://codereview.chromium.org/2820263005/diff/1/net/quic/quartc/quartc_stream_test.cc File net/quic/quartc/quartc_stream_test.cc (right): https://codereview.chromium.org/2820263005/diff/1/net/quic/quartc/quartc_stream_test.cc#newcode50 net/quic/quartc/quartc_stream_test.cc:50: return QuicConsumedData(len, fin); QuicConsumedData constructor should takes a boolean ...
3 years, 8 months ago (2017-04-18 22:17:56 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/2820263005/diff/1/net/quic/quartc/quartc_stream_test.cc File net/quic/quartc/quartc_stream_test.cc (right): https://codereview.chromium.org/2820263005/diff/1/net/quic/quartc/quartc_stream_test.cc#newcode50 net/quic/quartc/quartc_stream_test.cc:50: return QuicConsumedData(len, fin); On 2017/04/18 22:17:56, Zhongyi Shi wrote: ...
3 years, 8 months ago (2017-04-18 22:49:36 UTC) #4
Zhongyi Shi
3 years, 8 months ago (2017-04-18 22:53:10 UTC) #5 
lgtm

Powered by Google App Engine
This is Rietveld 408576698