Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Unified Diff: net/quic/core/quic_versions_test.cc

Issue 2827503003: deprecate -FLAGS_quic_reloadable_flag_quic_enable_version_37 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_versions_test.cc
diff --git a/net/quic/core/quic_versions_test.cc b/net/quic/core/quic_versions_test.cc
index d8089c29bf768ac159b0e475a0a820fdfa12d020..a87f225f6fab8a041b82a2a32fa9f7748c30bed8 100644
--- a/net/quic/core/quic_versions_test.cc
+++ b/net/quic/core/quic_versions_test.cc
@@ -125,25 +125,45 @@ TEST(QuicVersionsTest, QuicVersionToString) {
}
}
-TEST(QuicVersionsTest, FilterSupportedVersionsNo37) {
+TEST(QuicVersionsTest, FilterSupportedVersionsNo38) {
QuicFlagSaver flags;
QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
- QUIC_VERSION_37};
+ QUIC_VERSION_37, QUIC_VERSION_38,
+ QUIC_VERSION_39};
- FLAGS_quic_reloadable_flag_quic_enable_version_37 = false;
+ FLAGS_quic_reloadable_flag_quic_enable_version_38 = false;
QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
- ASSERT_EQ(2u, filtered_versions.size());
+ ASSERT_EQ(3u, filtered_versions.size());
EXPECT_EQ(QUIC_VERSION_35, filtered_versions[0]);
EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]);
+ EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]);
+}
+
+TEST(QuicVersionsTest, FilterSupportedVersionsNo39) {
+ QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
+ QUIC_VERSION_37, QUIC_VERSION_38,
+ QUIC_VERSION_39};
+
+ FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
+ base::SetFlag(&FLAGS_quic_enable_version_39, false);
+
+ QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
+ ASSERT_EQ(4u, filtered_versions.size());
+ EXPECT_EQ(QUIC_VERSION_35, filtered_versions[0]);
+ EXPECT_EQ(QUIC_VERSION_36, filtered_versions[1]);
+ EXPECT_EQ(QUIC_VERSION_37, filtered_versions[2]);
+ EXPECT_EQ(QUIC_VERSION_38, filtered_versions[3]);
}
TEST(QuicVersionsTest, FilterSupportedVersionsAllVersions) {
QuicFlagSaver flags;
QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
- QUIC_VERSION_37};
+ QUIC_VERSION_37, QUIC_VERSION_38,
+ QUIC_VERSION_39};
- FLAGS_quic_reloadable_flag_quic_enable_version_37 = true;
+ FLAGS_quic_reloadable_flag_quic_enable_version_38 = true;
+ base::SetFlag(&FLAGS_quic_enable_version_39, true);
QuicVersionVector filtered_versions = FilterSupportedVersions(all_versions);
ASSERT_EQ(all_versions, filtered_versions);
@@ -151,7 +171,8 @@ TEST(QuicVersionsTest, FilterSupportedVersionsAllVersions) {
TEST(QuicVersionsTest, LookUpVersionByIndex) {
QuicVersionVector all_versions = {QUIC_VERSION_35, QUIC_VERSION_36,
- QUIC_VERSION_37};
+ QUIC_VERSION_37, QUIC_VERSION_38,
+ QUIC_VERSION_39};
int version_count = all_versions.size();
for (int i = -5; i <= version_count + 1; ++i) {
if (i >= 0 && i < version_count) {
« no previous file with comments | « net/quic/core/quic_versions.cc ('k') | net/tools/quic/quic_dispatcher_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698