[Web Payments] Correct pluralization of "more items"

[Web Payments] Correct pluralization of "more items"

BUG=711058
Review-Url: https://codereview.chromium.org/2827293003
Cr-Commit-Position: refs/heads/master@{#466045}
Committed: https://chromium.googlesource.com/chromium/src/+/aaf5884039a25b4f67eec57428e5e61eade2eaf4

[anthonyvd, 2017-04-20 14:59:37]

anthonyvd@chromium.org changed reviewers:
+ mathp@chromium.org

[anthonyvd, 2017-04-20 14:59:37]

Hi Math, more UI tweaks. PTAL!

[please use gerrit instead, 2017-04-20 15:05:26]

rouslan@chromium.org changed reviewers:
+ rouslan@chromium.org

[please use gerrit instead, 2017-04-20 15:05:27]

https://codereview.chromium.org/2827293003/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2827293003/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:442:
base::string16 more_items_label =
Please see for an example of how this should be done correctly:

https://cs.chromium.org/chromium/src/ui/base/l10n/l10n_util.h?rcl=3cfcb7cdbff...

https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...

Some languages require special treatment of numbers other than 1. This is taken
care of by the framework.

https://codereview.chromium.org/2827293003/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2827293003/diff/1/components/payments_strings...
components/payments_strings.grdp:205: <ph name="ITEM_COUNT">$1<ex>2</ex></ph>
more items...
Please use the Unicode ellipsis "\u2026" instead of "...".

[anthonyvd, 2017-04-20 15:34:11]

Thanks for the comments, addressed them!

https://codereview.chromium.org/2827293003/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/payment_sheet_view_controller.cc (right):

https://codereview.chromium.org/2827293003/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/payment_sheet_view_controller.cc:442:
base::string16 more_items_label =
On 2017/04/20 at 15:05:27, ಠ_ಠ wrote:
> Please see for an example of how this should be done correctly:
> 
>
https://cs.chromium.org/chromium/src/ui/base/l10n/l10n_util.h?rcl=3cfcb7cdbff...
> 
>
https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...
> 
> Some languages require special treatment of numbers other than 1. This is
taken care of by the framework.

Ah, awesome! Done.

https://codereview.chromium.org/2827293003/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2827293003/diff/1/components/payments_strings...
components/payments_strings.grdp:205: <ph name="ITEM_COUNT">$1<ex>2</ex></ph>
more items...
On 2017/04/20 at 15:05:27, ಠ_ಠ wrote:
> Please use the Unicode ellipsis "\u2026" instead of "...".

Done.

[please use gerrit instead, 2017-04-20 15:38:20]

Please attach two screenshots of this patch in action to the bug report. One
screenshot should show "1 more item...". Another screenshot should show "2 more
items...". Thank you!

[anthonyvd, 2017-04-20 15:58:26]

On 2017/04/20 at 15:38:20, rouslan wrote:
> Please attach two screenshots of this patch in action to the bug report. One
screenshot should show "1 more item...". Another screenshot should show "2 more
items...". Thank you!

Sure thing, done.

[please use gerrit instead, 2017-04-20 15:59:41]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2017-04-20 15:59:41]

lgtm

[commit-bot: I haz the power, 2017-04-20 16:00:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:22:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492703981366860,
"parent_rev": "3180b5192164331d2ca5ce2619ce606cf8da2a48", "commit_rev":
"aaf5884039a25b4f67eec57428e5e61eade2eaf4"}

[commit-bot: I haz the power, 2017-04-20 17:22:24]

Description was changed from

==========
[Web Payments] Correct pluralization of "more items"

BUG=711058
==========

to

==========
[Web Payments] Correct pluralization of "more items"

BUG=711058

Review-Url: https://codereview.chromium.org/2827293003
Cr-Commit-Position: refs/heads/master@{#466045}
Committed:
https://chromium.googlesource.com/chromium/src/+/aaf5884039a25b4f67eec57428e5...
==========

[commit-bot: I haz the power, 2017-04-20 17:22:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/aaf5884039a25b4f67eec57428e5...