[Web Payments] Correct pluralization of "more items"

chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_sheet_view_controller.h"
 
 #include <algorithm>
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 421 matching lines @@
         new views::Label(base::ASCIIToUTF16(items[i]->label)));
 
     item_amounts_layout->StartRow(0, 0);
     item_amounts_layout->AddView(new views::Label(
         spec()->GetFormattedCurrencyAmount(items[i]->amount->value)));
   }
 
   int hidden_item_count = items.size() - kMaxNumberOfItemsShown;
   if (hidden_item_count > 0) {
     item_summaries_layout->StartRow(0, 0);
-    std::unique_ptr<views::Label> label = base::MakeUnique<views::Label>(
-        l10n_util::GetStringFUTF16(IDS_PAYMENT_REQUEST_ORDER_SUMMARY_MORE_ITEMS,
-                                   base::IntToString16(hidden_item_count)));
+    base::string16 more_items_label =

[please use gerrit instead, 2017/04/20 15:05:27]

Please see for an example of how this should be done correctly:

https://cs.chromium.org/chromium/src/ui/base/l10n/l10n_util.h?rcl=3cfcb7cdbff...

https://cs.chromium.org/chromium/src/chrome/android/java/strings/android_chro...

Some languages require special treatment of numbers other than 1. This is taken
care of by the framework.

[anthonyvd, 2017/04/20 15:34:10]

Ah, awesome! Done.

+        hidden_item_count == 1
+            ? l10n_util::GetStringUTF16(
+                  IDS_PAYMENT_REQUEST_ORDER_SUMMARY_ONE_MORE_ITEM)
+            : l10n_util::GetStringFUTF16(
+                  IDS_PAYMENT_REQUEST_ORDER_SUMMARY_MORE_ITEMS,
+                  base::IntToString16(hidden_item_count));
+    std::unique_ptr<views::Label> label =
+        base::MakeUnique<views::Label>(more_items_label);
     label->SetDisabledColor(label->GetNativeTheme()->GetSystemColor(
         ui::NativeTheme::kColorId_LabelDisabledColor));
     label->SetEnabled(false);
     item_summaries_layout->AddView(label.release());
 
     item_amounts_layout->StartRow(0, 0);
     item_amounts_layout->AddView(new views::Label(base::ASCIIToUTF16("")));
   }
 
   item_summaries_layout->StartRow(0, 0);
@@ skipping 225 matching lines @@
             PaymentSheetViewControllerTags::SHOW_SHIPPING_OPTION_BUTTON),
         static_cast<int>(
             DialogViewID::PAYMENT_SHEET_SHIPPING_OPTION_SECTION_BUTTON),
         widest_name_column_view_width_);
   }
 
   return section;
 }
 
 }  // namespace payments