Remove ClassicPendingScript::CreateForTesting()

Remove ClassicPendingScript::CreateForTesting()

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702
Review-Url: https://codereview.chromium.org/2827163003
Cr-Commit-Position: refs/heads/master@{#466902}
Committed: https://chromium.googlesource.com/chromium/src/+/3d792ae95a9b9e1efa7dfe380278182f94ac8755

[hiroshige, 2017-04-19 23:05:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:05:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-19 23:36:50]

Description was changed from

==========
Use MockScriptElementBase in ScriptStreamerTest

BUG=
==========

to

==========
Use MockScriptElementBase in ScriptStreamerTest

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702
==========

[hiroshige, 2017-04-19 23:36:50]

hiroshige@chromium.org changed reviewers:
+ japhet@chromium.org, kouhei@chromium.org, vogelheim@chromium.org

[hiroshige, 2017-04-19 23:37:13]

Description was changed from

==========
Use MockScriptElementBase in ScriptStreamerTest

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702
==========

to

==========
Remove ClassicPendingScript::CreateForTesting()

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702
==========

[hiroshige, 2017-04-19 23:47:51]

PTAL.

[commit-bot: I haz the power, 2017-04-20 00:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:59:08]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2017-04-21 17:41:13]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 17:41:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Nate Chapin, 2017-04-21 18:22:22]

lgtm

[haraken, 2017-04-21 19:15:19]

owner LGTM

[commit-bot: I haz the power, 2017-04-21 20:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 20:39:23]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kouhei (in TOK), 2017-04-23 07:01:47]

lgtm

[hiroshige, 2017-04-25 00:47:11]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 00:47:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 03:03:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 03:03:54]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-25 06:34:26]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-25 06:34:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, japhet@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2827163003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-25 06:34:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 06:38:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493102066259980,
"parent_rev": "dcf2424a1b4ebe7db1dde6ce81a267396787baed", "commit_rev":
"3d792ae95a9b9e1efa7dfe380278182f94ac8755"}

[commit-bot: I haz the power, 2017-04-25 06:38:50]

Description was changed from

==========
Remove ClassicPendingScript::CreateForTesting()

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702
==========

to

==========
Remove ClassicPendingScript::CreateForTesting()

This CL uses MockScriptElementBase instead of nullptr to create
ClassicPendingScript, in order to remove
ClassicPendingScript::CreateForTesting() and make |PendingScript::element_|
always non-null when used.

BUG=686281, 694702

Review-Url: https://codereview.chromium.org/2827163003
Cr-Commit-Position: refs/heads/master@{#466902}
Committed:
https://chromium.googlesource.com/chromium/src/+/3d792ae95a9b9e1efa7dfe380278...
==========

[commit-bot: I haz the power, 2017-04-25 06:38:51]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3d792ae95a9b9e1efa7dfe380278...