Remove ClassicPendingScript::CreateForTesting()

third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/dom/ClassicPendingScript.h"
 
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptStreamer.h"
 #include "bindings/core/v8/V8BindingForCore.h"
 #include "core/dom/Document.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/SubresourceIntegrity.h"
 #include "platform/loader/fetch/MemoryCache.h"
 
 namespace blink {
 
 ClassicPendingScript* ClassicPendingScript::Create(ScriptElementBase* element,
                                                    ScriptResource* resource) {
   return new ClassicPendingScript(element, resource, TextPosition());
 }
 
 ClassicPendingScript* ClassicPendingScript::Create(
     ScriptElementBase* element,
     const TextPosition& starting_position) {
   return new ClassicPendingScript(element, nullptr, starting_position);
 }
 
-ClassicPendingScript* ClassicPendingScript::CreateForTesting(
-    ScriptResource* resource) {
-  return new ClassicPendingScript(nullptr, resource, TextPosition(), true);
-}
-
 ClassicPendingScript::ClassicPendingScript(
     ScriptElementBase* element,
     ScriptResource* resource,
-    const TextPosition& starting_position,
-    bool is_for_testing)
-    : PendingScript(element, starting_position),
-      integrity_failure_(false),
-      is_for_testing_(is_for_testing) {
+    const TextPosition& starting_position)
+    : PendingScript(element, starting_position), integrity_failure_(false) {
   CheckState();
   SetResource(resource);
   MemoryCoordinator::Instance().RegisterClient(this);
 }
 
 ClassicPendingScript::~ClassicPendingScript() {}
 
 NOINLINE void ClassicPendingScript::CheckState() const {
   // TODO(hiroshige): Turn these CHECK()s into DCHECK() before going to beta.
-  CHECK(is_for_testing_ || GetElement());
+  CHECK(GetElement());
   CHECK(GetResource() || !streamer_);
   CHECK(!streamer_ || streamer_->GetResource() == GetResource());
 }
 
 NOINLINE void ClassicPendingScript::Dispose() {
   PendingScript::Dispose();
 }
 
 void ClassicPendingScript::DisposeInternal() {
   MemoryCoordinator::Instance().UnregisterClient(this);
@@ skipping 73 matching lines @@
   // In order to simulate the correct behavior, Blink explicitly does the SRI
   // checks here, when a PendingScript tied to a particular request is
   // finished (and in the case of a StyleSheet, at the point of execution),
   // while having proper Fetch checks in the fetch module for use in the
   // fetch JavaScript API. In a future world where the ResourceFetcher uses
   // the Fetch algorithm, this should be fixed by having separate Response
   // objects (perhaps attached to identical Resource objects) per request.
   //
   // See https://crbug.com/500701 for more information.
   CheckState();
-  if (!is_for_testing_ && GetElement()) {
+  if (GetElement()) {
     integrity_failure_ = !CheckScriptResourceIntegrity(resource, GetElement());
   }
 
   // If script streaming is in use, the client will be notified in
   // streamingFinished.
   if (streamer_)
     streamer_->NotifyFinished(resource);
   else if (Client())
     Client()->PendingScriptFinished(this);
 }
@@ skipping 79 matching lines @@
 
 KURL ClassicPendingScript::Url() const {
   return GetResource()->Url();
 }
 
 void ClassicPendingScript::RemoveFromMemoryCache() {
   GetMemoryCache()->Remove(GetResource());
 }
 
 }  // namespace blink