Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/core/dom/ClassicPendingScript.h

Issue 2827163003: Remove ClassicPendingScript::CreateForTesting() (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ClassicPendingScript.h
diff --git a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
index 1874164f003d7602c2c83f2e81139fd2d7387fad..a5184e2aa72b06fb70bd997a846ec77c6b47cdad 100644
--- a/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
+++ b/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
@@ -39,8 +39,6 @@ class CORE_EXPORT ClassicPendingScript final
// For inline script.
static ClassicPendingScript* Create(ScriptElementBase*, const TextPosition&);
- static ClassicPendingScript* CreateForTesting(ScriptResource*);
-
~ClassicPendingScript() override;
void SetStreamer(ScriptStreamer*);
@@ -72,8 +70,7 @@ class CORE_EXPORT ClassicPendingScript final
private:
ClassicPendingScript(ScriptElementBase*,
ScriptResource*,
- const TextPosition&,
- bool is_for_testing = false);
+ const TextPosition&);
ClassicPendingScript() = delete;
void CheckState() const override;
@@ -89,10 +86,6 @@ class CORE_EXPORT ClassicPendingScript final
bool integrity_failure_;
Member<ScriptStreamer> streamer_;
-
- // This flag is used to skip non-null checks of |m_element| in unit
- // tests, because |m_element| can be null in unit tests.
- const bool is_for_testing_;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698