Reland of In run-webkit-tests, start xvfb if necessary.

Reland of "In run-webkit-tests, start xvfb if necessary".

Original CL (https://codereview.chromium.org/2821543003) broke Android.

This is intended to be a reland of the original with modifications; it should only be committed after we get a successful run on android_blink_rel.

BUG=711515
Review-Url: https://codereview.chromium.org/2827073002
Cr-Commit-Position: refs/heads/master@{#465778}
Committed: https://chromium.googlesource.com/chromium/src/+/b8cba92beb55b43eba8fb7699452f7a278fc2398

[qyearsley, 2017-04-19 15:53:37]

Created Reland of In run-webkit-tests, start xvfb if necessary.

[qyearsley, 2017-04-19 16:01:37]

Description was changed from

==========
Reland of In run-webkit-tests, start xvfb if necessary. (patchset #1 id:1 of
https://codereview.chromium.org/2828623002/ )

Reason for revert:
Making a reland CL in order to try to fix the issue

Original issue's description:
> Revert of In run-webkit-tests, start xvfb if necessary. (patchset #6 id:100001
of https://codereview.chromium.org/2821543003/ )
> 
> Reason for revert:
> Looks like it broke WebKit Android (Nexus4). 
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...
> 
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit...
> 
> Original issue's description:
> > In run-webkit-tests, start xvfb if necessary.
> > 
> > BUG=711515
> > 
> > Review-Url: https://codereview.chromium.org/2821543003
> > Cr-Commit-Position: refs/heads/master@{#465331}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/8e209a99612f0af2a91c940967ea...
> 
> TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=711515
> 
> Review-Url: https://codereview.chromium.org/2828623002
> Cr-Commit-Position: refs/heads/master@{#465428}
> Committed:
https://chromium.googlesource.com/chromium/src/+/53b27041e4b3618926878898d8e5...

TBR=dpranke@chromium.org,tansell@chromium.org,ojan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=711515
==========

to

==========
Reland of "In run-webkit-tests, start xvfb if necessary".

Original CL (https://codereview.chromium.org/2821543003) broke Android.

This is intended to be a reland of the original with modifications; it should
only be committed after we get a successful run on android_blink_rel.

BUG=711515
==========

[qyearsley, 2017-04-19 20:11:29]

qyearsley@chromium.org changed reviewers:
- ojan@chromium.org

[qyearsley, 2017-04-19 20:11:30]

It looks like changing the order of the steps executed in manager.py does fix
the problem with android, does this look OK to try to reland?

[Dirk Pranke, 2017-04-19 20:15:28]

lgtm

[qyearsley, 2017-04-19 20:52:01]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:52:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 22:16:10]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1492635121932540,
"parent_rev": "b67d26269d76d560a3e7e39235404a101d3e7d15", "commit_rev":
"b8cba92beb55b43eba8fb7699452f7a278fc2398"}

[commit-bot: I haz the power, 2017-04-19 22:16:22]

Description was changed from

==========
Reland of "In run-webkit-tests, start xvfb if necessary".

Original CL (https://codereview.chromium.org/2821543003) broke Android.

This is intended to be a reland of the original with modifications; it should
only be committed after we get a successful run on android_blink_rel.

BUG=711515
==========

to

==========
Reland of "In run-webkit-tests, start xvfb if necessary".

Original CL (https://codereview.chromium.org/2821543003) broke Android.

This is intended to be a reland of the original with modifications; it should
only be committed after we get a successful run on android_blink_rel.

BUG=711515

Review-Url: https://codereview.chromium.org/2827073002
Cr-Commit-Position: refs/heads/master@{#465778}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8cba92beb55b43eba8fb7699452...
==========

[commit-bot: I haz the power, 2017-04-19 22:16:22]

Committed patchset #2 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/b8cba92beb55b43eba8fb7699452...

[kochi, 2017-04-20 05:00:49]

kochi@chromium.org changed reviewers:
+ kochi@chromium.org

[kochi, 2017-04-20 05:00:50]

After this commit, showing result summary HTML from
run_layout_tests.py complains that

[2007:2007:0420/135756.036924:ERROR:browser_main_loop.cc(279)] Gtk: cannot open
display: :99

because this script does not revert the change to the
DISPLAY env var?

[qyearsley, 2017-04-20 16:33:49]

On 2017/04/20 at 05:00:50, kochi wrote:
> After this commit, showing result summary HTML from
> run_layout_tests.py complains that
> 
> [2007:2007:0420/135756.036924:ERROR:browser_main_loop.cc(279)] Gtk: cannot
open display: :99
> 
> because this script does not revert the change to the
> DISPLAY env var?

Ah, that's right -- more discussion in the bug http://crbug.com/711515