Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py

Issue 2827073002: Reland of In run-webkit-tests, start xvfb if necessary. (Closed)
Patch Set: Make a minor change in the order of steps in Manager._set_up_run Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
index 6a792fcadb8a06fd9119c6fe3cd0febfc96109df..3f3aabf488cac2367919f1162fb9d453af26a68e 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
@@ -332,13 +332,6 @@ class Manager(object):
_log.error("Build check failed")
return exit_code
- # Check that the system dependencies (themes, fonts, ...) are correct.
- if not self._options.nocheck_sys_deps:
- self._printer.write_update("Checking system dependencies ...")
- exit_code = self._port.check_sys_deps(self._needs_servers(test_names))
- if exit_code:
- return exit_code
-
if self._options.clobber_old_results:
self._clobber_old_results()
elif self._filesystem.exists(self._results_directory):
@@ -350,6 +343,14 @@ class Manager(object):
self._port.host.filesystem.maybe_make_directory(self._results_directory)
self._port.setup_test_run()
+
+ # Check that the system dependencies (themes, fonts, ...) are correct.
+ if not self._options.nocheck_sys_deps:
+ self._printer.write_update("Checking system dependencies ...")
+ exit_code = self._port.check_sys_deps(self._needs_servers(test_names))
+ if exit_code:
+ return exit_code
+
return exit_codes.OK_EXIT_STATUS
def _run_tests(self, tests_to_run, tests_to_skip, repeat_each, iterations,

Powered by Google App Engine
This is Rietveld 408576698