Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 2828623002: Revert of In run-webkit-tests, start xvfb if necessary. (Closed)

Created:
3 years, 8 months ago by ojan
Modified:
3 years, 8 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of In run-webkit-tests, start xvfb if necessary. (patchset #6 id:100001 of https://codereview.chromium.org/2821543003/ ) Reason for revert: Looks like it broke WebKit Android (Nexus4). https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/63884 https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Android__Nexus4_%2F63893%2F%2B%2Frecipes%2Fsteps%2Fwebkit_tests%2F0%2Fstdout Original issue's description: > In run-webkit-tests, start xvfb if necessary. > > BUG=711515 > > Review-Url: https://codereview.chromium.org/2821543003 > Cr-Commit-Position: refs/heads/master@{#465331} > Committed: https://chromium.googlesource.com/chromium/src/+/8e209a99612f0af2a91c940967eacef653fa20b1 TBR=dpranke@chromium.org,tansell@chromium.org,qyearsley@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=711515 Review-Url: https://codereview.chromium.org/2828623002 Cr-Commit-Position: refs/heads/master@{#465428} Committed: https://chromium.googlesource.com/chromium/src/+/53b27041e4b3618926878898d8e57d7c7d73d157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -84 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/executive_mock.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py View 3 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py View 3 chunks +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
ojan
Created Revert of In run-webkit-tests, start xvfb if necessary.
3 years, 8 months ago (2017-04-19 00:17:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828623002/1
3 years, 8 months ago (2017-04-19 00:18:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/53b27041e4b3618926878898d8e57d7c7d73d157
3 years, 8 months ago (2017-04-19 00:20:20 UTC) #6
qyearsley
LGTM -- I was wondering why Android was failing like that, glad that the Android ...
3 years, 8 months ago (2017-04-19 15:53:18 UTC) #7
qyearsley
3 years, 8 months ago (2017-04-19 15:53:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2827073002/ by qyearsley@chromium.org.

The reason for reverting is: Making a reland CL in order to try to fix the
issue.

Powered by Google App Engine
This is Rietveld 408576698