Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2826493002: Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://coderev… (Closed)

Created:
3 years, 8 months ago by hiroshige
Modified:
3 years, 8 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Revert of Rename PendingScript::Url() to UrlForClassicScript() (patchset #1 id:1 of https://codereview.chromium.org/2815163005/ ) Reason for revert: https://codereview.chromium.org/2653923008/ is suspected to cause CHECK() failure (crbug.com/711703) inside PendingScript's prefinalizer. BUG=711703 Original issue's description: > Rename PendingScript::Url() to UrlForClassicScript() > > Because it is/can be used only for classic scripts. > > BUG=686281 > > Review-Url: https://codereview.chromium.org/2815163005 > Cr-Commit-Position: refs/heads/master@{#464613} > Committed: https://chromium.googlesource.com/chromium/src/+/06fcf4b92be26a28fde65c743e6a0d40bbc53dc0 TBR=kouhei@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=686281 Review-Url: https://codereview.chromium.org/2822763002 Cr-Commit-Position: refs/heads/master@{#464766} (cherry picked from commit 476b2ca298bce5eae94e680ce84ef56c08e28a2e) Review-Url: https://codereview.chromium.org/2826493002 . Cr-Commit-Position: refs/branch-heads/3071@{#17} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/4ef50c3d0a9efe019b290cb28844e1506c3da623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M third_party/WebKit/Source/core/dom/ClassicPendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/PendingScript.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
hiroshige
3 years, 8 months ago (2017-04-17 17:42:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4ef50c3d0a9efe019b290cb28844e1506c3da623.

Powered by Google App Engine
This is Rietveld 408576698