Expose internal treegrid role, do some cleanup for table/grid/treegrid handling

When an ARIA grid or treegrid is used, pass that role through while still supporting the table interface. Essentially, the grid/treegrid roles can be understood as a subclass of a table role. Also do some cleanup for table/grid/treegrid handling.

BUG=532670
Review-Url: https://codereview.chromium.org/2825803002
Cr-Commit-Position: refs/heads/master@{#465747}
Committed: https://chromium.googlesource.com/chromium/src/+/38718938990ffe5438bec707e982be6bcfac962b

[aleventhal, 2017-04-18 18:00:54]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:01:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 18:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 18:19:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-04-18 18:58:11]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 18:58:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-18 19:27:45]

Description was changed from

==========
Expose internal treegrid role, do some cleanup for table/grid/treegrid handling

BUG=532670
==========

to

==========
When an ARIA grid or treegrid is used, pass that role through while still
supporting the table interface. Essentially, the grid/treegrid roles can be
understood as a superclass of a table role. Also do some cleanup for
table/grid/treegrid handling.

BUG=532670
==========

[aleventhal, 2017-04-18 19:27:45]

aleventhal@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 19:54:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[aleventhal, 2017-04-18 20:20:32]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[aleventhal, 2017-04-18 20:21:13]

The CQ bit was unchecked by aleventhal@chromium.org

[commit-bot: I haz the power, 2017-04-18 20:21:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-18 20:25:26]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 20:25:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 21:22:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 21:22:47]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[aleventhal, 2017-04-18 21:42:29]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 21:43:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-18 21:56:10]

Description was changed from

==========
When an ARIA grid or treegrid is used, pass that role through while still
supporting the table interface. Essentially, the grid/treegrid roles can be
understood as a superclass of a table role. Also do some cleanup for
table/grid/treegrid handling.

BUG=532670
==========

to

==========
When an ARIA grid or treegrid is used, pass that role through while still
supporting the table interface. Essentially, the grid/treegrid roles can be
understood as a subclass of a table role. Also do some cleanup for
table/grid/treegrid handling.

BUG=532670
==========

[dmazzoni, 2017-04-18 21:59:37]

dmazzoni@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dmazzoni, 2017-04-18 21:59:38]

lgtm

@aboxhall, this is a fantastic example of where it'd be great
if we had the whole role hierarchy in some json5 file and
we could call some function to see if something has a role
of TABLE, or any subrole of TABLE.

https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_android.cc (right):

https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:177: return
(IsTableOrGridOrTreeGridRole() || GetRole() == ui::AX_ROLE_LIST ||
Maybe IsTableLikeRole?

https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:672: const bool
isTableLikeRole = dst->role == ui::AX_ROLE_TABLE ||
nit: is_table_like_role

[aboxhall, 2017-04-18 22:44:50]

On 2017/04/18 21:59:38, dmazzoni wrote:
> lgtm
> 
> @aboxhall, this is a fantastic example of where it'd be great
> if we had the whole role hierarchy in some json5 file and
> we could call some function to see if something has a role
> of TABLE, or any subrole of TABLE.

Ooh, I think I can start work on that today actually :D

>
https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
> File content/browser/accessibility/browser_accessibility_android.cc (right):
> 
>
https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
> content/browser/accessibility/browser_accessibility_android.cc:177: return
> (IsTableOrGridOrTreeGridRole() || GetRole() == ui::AX_ROLE_LIST ||
> Maybe IsTableLikeRole?
> 
>
https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
> File content/renderer/accessibility/blink_ax_tree_source.cc (right):
> 
>
https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
> content/renderer/accessibility/blink_ax_tree_source.cc:672: const bool
> isTableLikeRole = dst->role == ui::AX_ROLE_TABLE ||
> nit: is_table_like_role

[commit-bot: I haz the power, 2017-04-18 22:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 22:47:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[aleventhal, 2017-04-19 12:06:21]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 12:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 14:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 14:23:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-04-19 14:34:59]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 14:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 16:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 16:56:40]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[aleventhal, 2017-04-19 18:02:58]

The CQ bit was checked by aleventhal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 18:03:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[aleventhal, 2017-04-19 20:24:02]

https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
File content/browser/accessibility/browser_accessibility_android.cc (right):

https://codereview.chromium.org/2825803002/diff/70001/content/browser/accessi...
content/browser/accessibility/browser_accessibility_android.cc:177: return
(IsTableOrGridOrTreeGridRole() || GetRole() == ui::AX_ROLE_LIST ||
On 2017/04/18 21:59:38, dmazzoni wrote:
> Maybe IsTableLikeRole?

Done.

https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/2825803002/diff/70001/content/renderer/access...
content/renderer/accessibility/blink_ax_tree_source.cc:672: const bool
isTableLikeRole = dst->role == ui::AX_ROLE_TABLE ||
On 2017/04/18 21:59:38, dmazzoni wrote:
> nit: is_table_like_role

Done.

[commit-bot: I haz the power, 2017-04-19 20:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 20:28:16]

Dry run: This issue passed the CQ dry run.

[aleventhal, 2017-04-19 21:03:45]

The CQ bit was checked by aleventhal@chromium.org

[aleventhal, 2017-04-19 21:03:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2825803002/#ps130001
(title: "Fix mac tests")

[commit-bot: I haz the power, 2017-04-19 21:04:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:13:50]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1492635825749690,
"parent_rev": "7b4caa4232e5c7246d43fc954264754b6f396bf8", "commit_rev":
"38718938990ffe5438bec707e982be6bcfac962b"}

[commit-bot: I haz the power, 2017-04-19 21:14:23]

Description was changed from

==========
When an ARIA grid or treegrid is used, pass that role through while still
supporting the table interface. Essentially, the grid/treegrid roles can be
understood as a subclass of a table role. Also do some cleanup for
table/grid/treegrid handling.

BUG=532670
==========

to

==========
When an ARIA grid or treegrid is used, pass that role through while still
supporting the table interface. Essentially, the grid/treegrid roles can be
understood as a subclass of a table role. Also do some cleanup for
table/grid/treegrid handling.

BUG=532670

Review-Url: https://codereview.chromium.org/2825803002
Cr-Commit-Position: refs/heads/master@{#465747}
Committed:
https://chromium.googlesource.com/chromium/src/+/38718938990ffe5438bec707e982...
==========

[commit-bot: I haz the power, 2017-04-19 21:14:26]

Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/chromium/src/+/38718938990ffe5438bec707e982...