content/browser/accessibility/one_shot_accessibility_tree_search.cc - Issue 2825803002: Expose internal treegrid role, do some cleanup for table/grid/treegrid handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/one_shot_accessibility_tree_search.cc

Issue 2825803002: Expose internal treegrid role, do some cleanup for table/grid/treegrid handling (Closed)

Patch Set: Fix mac tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_tree_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/one_shot_accessibility_tree_search.cc

diff --git a/content/browser/accessibility/one_shot_accessibility_tree_search.cc b/content/browser/accessibility/one_shot_accessibility_tree_search.cc

index 4a0d4bc9c6802510ca6e23d5307ab8eff95f0fcd..7cfbd16b5d8110b4931d2ba12341066eeaa34abe 100644

--- a/content/browser/accessibility/one_shot_accessibility_tree_search.cc

+++ b/content/browser/accessibility/one_shot_accessibility_tree_search.cc

@@ -409,8 +409,7 @@ bool AccessibilityRadioGroupPredicate(

bool AccessibilityTablePredicate(

BrowserAccessibility* start, BrowserAccessibility* node) {

- return (node->GetRole() == ui::AX_ROLE_TABLE ||

- node->GetRole() == ui::AX_ROLE_GRID);

+ return node->IsTableLikeRole();

}

bool AccessibilityTextfieldPredicate(