Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: content/browser/accessibility/browser_accessibility.cc

Issue 2825803002: Expose internal treegrid role, do some cleanup for table/grid/treegrid handling (Closed)
Patch Set: Fix mac tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility.cc
diff --git a/content/browser/accessibility/browser_accessibility.cc b/content/browser/accessibility/browser_accessibility.cc
index 9639954401b0bfa564832426e971fd6466394510..95647cb7b211f539967c7e0611bba5342ecc1398 100644
--- a/content/browser/accessibility/browser_accessibility.cc
+++ b/content/browser/accessibility/browser_accessibility.cc
@@ -781,13 +781,13 @@ bool BrowserAccessibility::GetAriaTristate(
BrowserAccessibility* BrowserAccessibility::GetTable() const {
BrowserAccessibility* table = const_cast<BrowserAccessibility*>(this);
- while (table && !table->IsTableOrGridOrTreeGridRole())
+ while (table && !table->IsTableLikeRole())
table = table->PlatformGetParent();
return table;
}
BrowserAccessibility* BrowserAccessibility::GetTableCell(int index) const {
- if (!IsTableOrGridOrTreeGridRole() && !IsCellOrTableHeaderRole())
+ if (!IsTableLikeRole() && !IsCellOrTableHeaderRole())
return nullptr;
BrowserAccessibility* table = GetTable();
@@ -802,7 +802,7 @@ BrowserAccessibility* BrowserAccessibility::GetTableCell(int index) const {
BrowserAccessibility* BrowserAccessibility::GetTableCell(int row,
int column) const {
- if (!IsTableOrGridOrTreeGridRole() && !IsCellOrTableHeaderRole())
+ if (!IsTableLikeRole() && !IsCellOrTableHeaderRole())
return nullptr;
if (row < 0 || row >= GetTableRowCount() || column < 0 ||
column >= GetTableColumnCount()) {
@@ -901,7 +901,7 @@ bool BrowserAccessibility::IsCellOrTableHeaderRole() const {
GetRole() == ui::AX_ROLE_ROW_HEADER);
}
-bool BrowserAccessibility::IsTableOrGridOrTreeGridRole() const {
+bool BrowserAccessibility::IsTableLikeRole() const {
return (GetRole() == ui::AX_ROLE_TABLE ||
GetRole() == ui::AX_ROLE_GRID ||
GetRole() == ui::AX_ROLE_TREE_GRID);
« no previous file with comments | « content/browser/accessibility/browser_accessibility.h ('k') | content/browser/accessibility/browser_accessibility_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698