Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2828543002: Let QUIC be able to add random padding of [1,256] bytes after fin is consumed for a stream. Random … (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton
Modified:
3 years, 8 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Let QUIC be able to add random padding of [1,256] bytes after fin is consumed for a stream. Random paddings have the lowest priority to send. Not used in prod yet. Merge internal change: 153055858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -61 lines) Patch
M net/quic/core/quic_connection.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/core/quic_connection_test.cc View 7 chunks +18 lines, -9 lines 0 comments Download
M net/quic/core/quic_constants.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/core/quic_packet_creator.h View 4 chunks +18 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_creator.cc View 9 chunks +35 lines, -9 lines 0 comments Download
M net/quic/core/quic_packet_creator_test.cc View 4 chunks +179 lines, -3 lines 0 comments Download
M net/quic/core/quic_packet_generator.h View 4 chunks +14 lines, -1 line 0 comments Download
M net/quic/core/quic_packet_generator.cc View 7 chunks +25 lines, -4 lines 0 comments Download
M net/quic/core/quic_packet_generator_test.cc View 28 chunks +174 lines, -30 lines 0 comments Download
M net/quic/core/quic_types.h View 1 chunk +10 lines, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 3 chunks +8 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 3 (1 generated)
Ryan Hamilton
3 years, 8 months ago (2017-04-18 19:02:23 UTC) #2
Zhongyi Shi
3 years, 8 months ago (2017-04-18 22:01:18 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698