Issue 2828523003: Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled position because it neve…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2828523003: Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled position because it neve… (Closed)

Created:
3 years, 8 months ago by Ryan Hamilton

Modified:
3 years, 8 months ago

Reviewers:
Zhongyi Shi

CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Deprecate FLAGS_quic_reloadable_flag_quic_bbr_ack_spacing2 in the disabled position because it never worked that well. Merge internal change: 152853633

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -95 lines)			Patch
M	net/quic/core/congestion_control/bbr_sender.h	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender.cc	View	4 chunks	+0 lines, -48 lines	0 comments	Download
M	net/quic/core/congestion_control/bbr_sender_test.cc	View	4 chunks	+0 lines, -31 lines	0 comments	Download
M	net/quic/core/quic_flags_list.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 2825523003 Patch 1

Dependent Patchsets:

Issue 2825493004 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages