Reform editing/execCommand/delete-non-editable-range-crash.html

Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710864
Review-Url: https://codereview.chromium.org/2824633002
Cr-Commit-Position: refs/heads/master@{#464899}
Committed: https://chromium.googlesource.com/chromium/src/+/e058730765c6e22261750811bd6587ea4ec1ac37

[Xiaocheng, 2017-04-15 00:12:04]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-15 00:12:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-04-15 00:17:28]

Description was changed from

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

BUG=679977, 710684
==========

to

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710684
==========

[commit-bot: I haz the power, 2017-04-15 01:46:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-15 01:46:16]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-04-15 04:37:31]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-04-15 04:37:32]

PTAL.

https://codereview.chromium.org/2824633002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
(right):

https://codereview.chromium.org/2824633002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp:1064:
// editing/execCommand/delete-non-editable-range-crash.html reaches here.
I manually checked that the converted test does reach here.

[Xiaocheng, 2017-04-17 03:21:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 03:21:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 05:11:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 05:11:58]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2017-04-17 06:13:24]

Description was changed from

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710684
==========

to

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710864
==========

[Xiaocheng, 2017-04-17 06:13:43]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2017-04-17 06:13:44]

+tkent

[yosin_UTC9, 2017-04-17 06:32:14]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-04-17 06:32:14]

lgtm

[commit-bot: I haz the power, 2017-04-17 06:32:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 06:36:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492410734150280, "parent_rev":
"1c4480e43a3a1592fcd6f8bd6049580932a1a2c8", "commit_rev":
"e058730765c6e22261750811bd6587ea4ec1ac37"}

[commit-bot: I haz the power, 2017-04-17 06:37:07]

Description was changed from

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710864
==========

to

==========
Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977, 710864

Review-Url: https://codereview.chromium.org/2824633002
Cr-Commit-Position: refs/heads/master@{#464899}
Committed:
https://chromium.googlesource.com/chromium/src/+/e058730765c6e22261750811bd65...
==========

[commit-bot: I haz the power, 2017-04-17 06:37:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e058730765c6e22261750811bd65...