Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2824633002: Reform editing/execCommand/delete-non-editable-range-crash.html (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/execCommand/delete-non-editable-range-crash-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
index 7a9c48e5dc5b44be4ff5243ea253430aea36f36f..7cb0b53545e866f197a4dcbe8312615db5eb1c9f 100644
--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp
@@ -1060,8 +1060,10 @@ void DeleteSelectionCommand::DoApply(EditingState* editing_state) {
selection_to_delete_ = EndingSelection();
if (!selection_to_delete_.IsNonOrphanedRange() ||
- !selection_to_delete_.IsContentEditable())
+ !selection_to_delete_.IsContentEditable()) {
+ // editing/execCommand/delete-non-editable-range-crash.html reaches here.
Xiaocheng 2017/04/15 04:37:32 I manually checked that the converted test does re
return;
+ }
RelocatablePosition relocatable_reference_position(reference_move_position_);
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/execCommand/delete-non-editable-range-crash-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698