Reform editing/execCommand/delete-non-editable-range-crash.html

third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1042 matching lines @@
   }
 }
 
 void DeleteSelectionCommand::DoApply(EditingState* editing_state) {
   // If selection has not been set to a custom selection when the command was
   // created, use the current ending selection.
   if (!has_selection_to_delete_)
     selection_to_delete_ = EndingSelection();
 
   if (!selection_to_delete_.IsNonOrphanedRange() ||
-      !selection_to_delete_.IsContentEditable())
+      !selection_to_delete_.IsContentEditable()) {
+    // editing/execCommand/delete-non-editable-range-crash.html reaches here.

[Xiaocheng, 2017/04/15 04:37:32]

I manually checked that the converted test does reach here.

     return;
+  }
 
   RelocatablePosition relocatable_reference_position(reference_move_position_);
 
   // save this to later make the selection with
   TextAffinity affinity = selection_to_delete_.Affinity();
 
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
 
   Position downstream_end =
       MostForwardCaretPosition(selection_to_delete_.end());
@@ skipping 169 matching lines @@
   visitor->Trace(delete_into_blockquote_style_);
   visitor->Trace(start_root_);
   visitor->Trace(end_root_);
   visitor->Trace(start_table_row_);
   visitor->Trace(end_table_row_);
   visitor->Trace(temporary_placeholder_);
   CompositeEditCommand::Trace(visitor);
 }
 
 }  // namespace blink