Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2824283004: Mark some PrintPreviewUI methods as const. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
rbpotter
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark some PrintPreviewUI methods as const. Same for the rest of the call chain. Review-Url: https://codereview.chromium.org/2824283004 Cr-Commit-Position: refs/heads/master@{#465688} Committed: https://chromium.googlesource.com/chromium/src/+/77f3542894742c1351f9a02638f46752e6db9c40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M chrome/browser/printing/print_preview_data_service.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_preview_data_service.cc View 4 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.h View 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 4 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 8 months ago (2017-04-18 23:06:32 UTC) #6
rbpotter
On 2017/04/18 23:06:32, Lei Zhang wrote: lgtm
3 years, 8 months ago (2017-04-19 18:51:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2824283004/1
3 years, 8 months ago (2017-04-19 18:55:18 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-19 19:06:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77f3542894742c1351f9a02638f4...

Powered by Google App Engine
This is Rietveld 408576698