chrome/browser/ui/webui/print_preview/print_preview_handler.cc - Issue 2824283004: Mark some PrintPreviewUI methods as const.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

Issue 2824283004: Mark some PrintPreviewUI methods as const. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/print_preview/print_preview_handler.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

index 8ab3ddd53057ed58b09fc5ba6d62b5c18a8ac284..9dc9d445f6404e5d34f27a50800b1962ce1fca9f 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc

@@ -1019,7 +1019,7 @@ void PrintPreviewHandler::PrintToPdf() {

!select_file_dialog_->IsRunning(platform_util::GetTopLevel(

preview_web_contents()->GetNativeView()))) {

// Pre-populating select file dialog with print job title.

- base::string16 print_job_title_utf16 =

+ const base::string16& print_job_title_utf16 =

print_preview_ui()->initiator_title();

#if defined(OS_WIN)