Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1624)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.h

Issue 2824283004: Mark some PrintPreviewUI methods as const. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.h
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
index 143917b9d0f3de954859dc616a5eeda8b4ff4bc6..360a1cd23ef161981de385f6941302161303406e 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h
@@ -17,7 +17,6 @@
#include "chrome/browser/ui/webui/constrained_web_dialog_ui.h"
#include "printing/features/features.h"
-class PrintPreviewDataService;
class PrintPreviewHandler;
struct PrintHostMsg_DidGetPreviewPageCount_Params;
struct PrintHostMsg_RequestPrintPreview_Params;
@@ -44,8 +43,9 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
// Gets the print preview |data|. |index| is zero-based, and can be
// |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to get the entire preview
// document.
- void GetPrintPreviewDataForIndex(int index,
- scoped_refptr<base::RefCountedBytes>* data);
+ void GetPrintPreviewDataForIndex(
+ int index,
+ scoped_refptr<base::RefCountedBytes>* data) const;
// Sets the print preview |data|. |index| is zero-based, and can be
// |printing::COMPLETE_PREVIEW_DOCUMENT_INDEX| to set the entire preview
@@ -57,18 +57,18 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
void ClearAllPreviewData();
// Returns the available draft page count.
- int GetAvailableDraftPageCount();
+ int GetAvailableDraftPageCount() const;
// Setters
void SetInitiatorTitle(const base::string16& initiator_title);
- base::string16 initiator_title() { return initiator_title_; }
+ const base::string16& initiator_title() const { return initiator_title_; }
- bool source_is_modifiable() { return source_is_modifiable_; }
+ bool source_is_modifiable() const { return source_is_modifiable_; }
- bool source_has_selection() { return source_has_selection_; }
+ bool source_has_selection() const { return source_has_selection_; }
- bool print_selection_only() { return print_selection_only_; }
+ bool print_selection_only() const { return print_selection_only_; }
// Set initial settings for PrintPreviewUI.
static void SetInitialParams(
@@ -162,9 +162,6 @@ class PrintPreviewUI : public ConstrainedWebDialogUI {
FRIEND_TEST_ALL_PREFIXES(PrintPreviewDialogControllerUnitTest,
TitleAfterReload);
- // Returns the Singleton instance of the PrintPreviewDataService.
- PrintPreviewDataService* print_preview_data_service();
-
base::TimeTicks initial_preview_start_time_;
// The unique ID for this class instance. Stored here to avoid calling

Powered by Google App Engine
This is Rietveld 408576698