Allow to use measured width in translate overflow menu

Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

BUG=709964
Review-Url: https://codereview.chromium.org/2824083003
Cr-Commit-Position: refs/heads/master@{#468518}
Committed: https://chromium.googlesource.com/chromium/src/+/9146de1595631f543f2388239efba1ed1362704a

[Marti Wong, 2017-04-18 04:07:37]

The CQ bit was checked by martiw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 04:07:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marti Wong, 2017-04-18 04:10:19]

Description was changed from

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width to make
sure all items fit inside the menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width so that it won't take a long time to measure all item
widths.

We should use separate TranslateMenuHelper instance for overflow menu
and language menu so that each of them has it's own listPopupWindow.
Otherwise, if they share the same listPopupWindow, there will be a
jumpy animation and other ui bug when transforming from overflow menu
to language menu.

BUG=709964
==========

to

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

We should use separate TranslateMenuHelper instance for overflow menu
and language menu so that each of them has it's own listPopupWindow.
Otherwise, if they share the same listPopupWindow, there will be a
jumpy animation and other ui bug when transforming from overflow menu
to language menu.

BUG=709964
==========

[Marti Wong, 2017-04-18 04:10:19]

martiw@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Marti Wong, 2017-04-18 04:11:53]

Description was changed from

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

We should use separate TranslateMenuHelper instance for overflow menu
and language menu so that each of them has it's own listPopupWindow.
Otherwise, if they share the same listPopupWindow, there will be a
jumpy animation and other ui bug when transforming from overflow menu
to language menu.

BUG=709964
==========

to

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

BUG=709964
==========

[Marti Wong, 2017-04-18 04:19:48]

PTAL thanks again~!!

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:84:
void onTranslateMenuItemClicked(String code, int type);
In the previous CL, I thought that overflow menu and 'more languages'
menu could share the same TranslateMenuHelper object and when
transforming from overflow item to 'more languages' menu, we don't
need to dismiss the menu but we replace the items inside.

This approach has 2 problems when width is changed:
1. jumpy animation 
2. a ui bug (width suddenly change when clicking)

Therefore, I suggest that we should use separate TranslateMenuHelper
object for these 2 menus so that each of them has it's own
listPopupWindow.  We just dismiss the first one and showing another one.

Since menu will always dismiss, the return boolean here is no longer needed.

[commit-bot: I haz the power, 2017-04-18 04:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 04:45:55]

Dry run: This issue passed the CQ dry run.

[gone, 2017-04-18 23:49:18]

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
private int measureMenuWidth(TranslateMenuAdapter adapter) {
This ends up creating the View for every single item in the list.  Can you just
do something like what InfoBarControlLayout#computeMinWidthRequiredForValues()
does?

[gone, 2017-04-19 01:50:50]

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:127:
mPopup.setWidth(measureMenuWidth(mAdapter) + bgPadding.left + bgPadding.right);
test what happens if you set the width really large (larger than the phone
screen is)

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
private int measureMenuWidth(TranslateMenuAdapter adapter) {
On 2017/04/18 23:49:18, ping past 24hrs (dfalcantara) wrote:
> This ends up creating the View for every single item in the list.  Can you
just
> do something like what InfoBarControlLayout#computeMinWidthRequiredForValues()
> does?

If you fix your getView call to properly use the convertView, you're probably
fine.

[Marti Wong, 2017-04-19 04:00:09]

On 2017/04/19 01:50:50, ping past 24hrs (dfalcantara) wrote:
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
> (right):
> 
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:127:
> mPopup.setWidth(measureMenuWidth(mAdapter) + bgPadding.left +
bgPadding.right);
> test what happens if you set the width really large (larger than the phone
> screen is)
> 
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
> private int measureMenuWidth(TranslateMenuAdapter adapter) {
> On 2017/04/18 23:49:18, ping past 24hrs (dfalcantara) wrote:
> > This ends up creating the View for every single item in the list.  Can you
> just
> > do something like what
InfoBarControlLayout#computeMinWidthRequiredForValues()
> > does?
> 
> If you fix your getView call to properly use the convertView, you're probably
> fine.

Thanks for the review~!
Leo is working on the getView and make it uses the convertView properly.
I will revisit this CL after his CL is landed.  Thanks again!

[Marti Wong, 2017-04-26 07:52:17]

Patchset #2 (id:20001) has been deleted

[Marti Wong, 2017-04-26 08:47:00]

On 2017/04/19 04:00:09, Marti Wong wrote:
> On 2017/04/19 01:50:50, ping past 24hrs (dfalcantara) wrote:
> >
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
> > File
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
> > (right):
> > 
> >
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:127:
> > mPopup.setWidth(measureMenuWidth(mAdapter) + bgPadding.left +
> bgPadding.right);
> > test what happens if you set the width really large (larger than the phone
> > screen is)
> > 
> >
>
https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
> >
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
> > private int measureMenuWidth(TranslateMenuAdapter adapter) {
> > On 2017/04/18 23:49:18, ping past 24hrs (dfalcantara) wrote:
> > > This ends up creating the View for every single item in the list.  Can you
> > just
> > > do something like what
> InfoBarControlLayout#computeMinWidthRequiredForValues()
> > > does?
> > 
> > If you fix your getView call to properly use the convertView, you're
probably
> > fine.
> 
> Thanks for the review~!
> Leo is working on the getView and make it uses the convertView properly.
> I will revisit this CL after his CL is landed.  Thanks again!

PTAL

CL updated.
It sets the menu y-offset (to shift down the menu to make it cover the menu
button)
And the checkbox layouts are added.

thanks again~!

[Marti Wong, 2017-04-26 08:47:12]

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:127:
mPopup.setWidth(measureMenuWidth(mAdapter) + bgPadding.left + bgPadding.right);
On 2017/04/19 01:50:50, slow (dfalcantara) wrote:
> test what happens if you set the width really large (larger than the phone
> screen is)

Tested.  Menu width will be limited by the screen width.

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
private int measureMenuWidth(TranslateMenuAdapter adapter) {
On 2017/04/18 23:49:18, slow (dfalcantara) wrote:
> This ends up creating the View for every single item in the list.  Can you
just
> do something like what InfoBarControlLayout#computeMinWidthRequiredForValues()
> does?

googleo@ has fixed getView and it won't create Views every time.  see if it is
okay now.

https://codereview.chromium.org/2824083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:136:
private int measureMenuWidth(TranslateMenuAdapter adapter) {
On 2017/04/19 01:50:50, slow (dfalcantara) wrote:
> On 2017/04/18 23:49:18, ping past 24hrs (dfalcantara) wrote:
> > This ends up creating the View for every single item in the list.  Can you
> just
> > do something like what
InfoBarControlLayout#computeMinWidthRequiredForValues()
> > does?
> 
> If you fix your getView call to properly use the convertView, you're probably
> fine.

Ack. Thanks.

[Marti Wong, 2017-04-26 08:47:41]

PTAL

CL updated.
It sets the menu y-offset (to shift down the menu to make it cover the menu
button)
And the checkbox layouts are added.

thanks again~!

[gone, 2017-04-26 17:06:09]

dfalcantara@chromium.org changed reviewers:
+ twellington@chromium.org

[gone, 2017-04-26 17:06:10]

Delegating to Theresa for menu placement.

[Theresa, 2017-04-26 18:10:17]

https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:109:
}
This menu placement lgtm (it's the same as what we're doing for the app menu in
Chrome Home).

The background we use for popup windows has shadows that make the placement not
quite right when displayed at the bottom the screen, so I expect there will be
some follow up polish needed. Are there screenshots of what this currently looks
like?

[Marti Wong, 2017-04-27 00:15:58]

The CQ bit was checked by martiw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 00:16:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marti Wong, 2017-04-27 00:37:29]

Thanks Dan and Theresa.

Below is the screenshot:
https://drive.google.com/open?id=0B1O0Z7eoZMuGZXhOU0VsM2RKMGM

https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:109:
}
On 2017/04/26 18:10:17, Theresa wrote:
> This menu placement lgtm (it's the same as what we're doing for the app menu
in
> Chrome Home).
> 
> The background we use for popup windows has shadows that make the placement
not
> quite right when displayed at the bottom the screen, so I expect there will be
> some follow up polish needed. Are there screenshots of what this currently
looks
> like?

Thanks for the advice.  Yah it seems we might need a background with less drop
shadow at the bottom.  I added a TODO here.

[Marti Wong, 2017-04-27 03:31:45]

On 2017/04/27 00:37:29, Marti Wong wrote:
> Thanks Dan and Theresa.
> 
> Below is the screenshot:
> https://drive.google.com/open?id=0B1O0Z7eoZMuGZXhOU0VsM2RKMGM
> 
>
https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
> File
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
> (right):
> 
>
https://codereview.chromium.org/2824083003/diff/40001/chrome/android/java/src...
>
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:109:
> }
> On 2017/04/26 18:10:17, Theresa wrote:
> > This menu placement lgtm (it's the same as what we're doing for the app menu
> in
> > Chrome Home).
> > 
> > The background we use for popup windows has shadows that make the placement
> not
> > quite right when displayed at the bottom the screen, so I expect there will
be
> > some follow up polish needed. Are there screenshots of what this currently
> looks
> > like?
> 
> Thanks for the advice.  Yah it seems we might need a background with less drop
> shadow at the bottom.  I added a TODO here.

Hi Dan & Theresa,
See if you'll have other comments besides menu placement.
Thanks again~!

[Leo, 2017-04-27 06:25:47]

googleo@chromium.org changed reviewers:
+ googleo@chromium.org

[Leo, 2017-04-27 06:25:48]

Add some comments.

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:83:
if (mLanguageMenuHelper == null) {
Maybe you can pass the menu type to init the type of menu helper when it's
needed.

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java:66:
OVERFLOW_MENU.add(new MenuItem(
We shouldn't toggle the logic here. This is a static method used for all Tabs.

I think we should always return Checkbox item type, then set the checkbox status
selected or not when rendering the menu item.

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:40:
private final int[] mTempLocation;
This is only used between the line 132~135, right?
Why not create it on demand.

[Marti Wong, 2017-04-27 08:19:58]

The CQ bit was checked by martiw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 08:20:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marti Wong, 2017-04-27 08:21:14]

The CQ bit was unchecked by martiw@chromium.org

[Marti Wong, 2017-04-27 08:24:26]

Fixed things according to Leo's comments.
PTAL and see if there's any thing else. thx~!

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:83:
if (mLanguageMenuHelper == null) {
On 2017/04/27 06:25:48, Leo wrote:
> Maybe you can pass the menu type to init the type of menu helper when it's
> needed.

Done. thanks~!

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java:66:
OVERFLOW_MENU.add(new MenuItem(
On 2017/04/27 06:25:48, Leo wrote:
> We shouldn't toggle the logic here. This is a static method used for all Tabs.
> 
> I think we should always return Checkbox item type, then set the checkbox
status
> selected or not when rendering the menu item.

Done.

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/80001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:40:
private final int[] mTempLocation;
On 2017/04/27 06:25:48, Leo wrote:
> This is only used between the line 132~135, right?
> Why not create it on demand.

Done.

[gone, 2017-04-27 18:56:18]

lgtm % comments

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:33:
// Need 2 instances of TranslateMenuHelper to prevent a racing condition bug
which happens when
race condition.

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:102:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
Should this be moved to ApiCompatibilityUtils#setVerticalOffset(ListPopupWindow,
baseOffset, anchorHeight)?

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:118:
// Use measured width when it is a overflow menu
periods everywhere

[Marti Wong, 2017-04-28 00:21:04]

Thanks guys for the review.
Committing

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
(right):

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java:33:
// Need 2 instances of TranslateMenuHelper to prevent a racing condition bug
which happens when
On 2017/04/27 18:56:18, slow (dfalcantara) wrote:
> race condition.

Done.

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java
(right):

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:102:
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) {
On 2017/04/27 18:56:18, slow (dfalcantara) wrote:
> Should this be moved to
ApiCompatibilityUtils#setVerticalOffset(ListPopupWindow,
> baseOffset, anchorHeight)?

Thanks for the advice!
I will leave this alone at the moment.
If we made ApiCompatibilityUtils#setVerticalOffset, AppMenu.java and this file
could be the only places to use that.  But I still could not fully understand
AppMenu.java (why padding.bottom and mNegativeSoftwareVerticalOffset don't need
to change sign).  not confident to touch that.

https://codereview.chromium.org/2824083003/diff/100001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java:118:
// Use measured width when it is a overflow menu
On 2017/04/27 18:56:18, slow (dfalcantara) wrote:
> periods everywhere

Done.

[Marti Wong, 2017-04-28 03:53:18]

The CQ bit was checked by martiw@chromium.org

[Marti Wong, 2017-04-28 03:53:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2824083003/#ps140001
(title: "remove unused function")

[commit-bot: I haz the power, 2017-04-28 03:53:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:57:55]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marti Wong, 2017-04-28 05:00:56]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:01:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:05:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:05:03]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marti Wong, 2017-04-28 05:40:14]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:40:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 05:44:26]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Marti Wong, 2017-04-28 07:50:59]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:51:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 07:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:54:20]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marti Wong, 2017-04-28 22:03:06]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:04:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 22:09:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:09:14]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marti Wong, 2017-04-30 00:24:54]

The CQ bit was checked by martiw@chromium.org

[commit-bot: I haz the power, 2017-04-30 00:25:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 00:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 00:28:24]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gone, 2017-04-30 01:27:36]

This is going to keep failing until you sync.

[Marti Wong, 2017-04-30 23:12:36]

Thanks Dan!
Will do the sync when I back to office tmr.

On Sun, 30 Apr 2017 at 11:27 AM <dfalcantara@chromium.org> wrote:

> This is going to keep failing until you sync.
>
> https://codereview.chromium.org/2824083003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Marti Wong, 2017-05-02 00:11:29]

The CQ bit was checked by martiw@chromium.org

[Marti Wong, 2017-05-02 00:11:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2824083003/#ps160001
(title: "sync")

[commit-bot: I haz the power, 2017-05-02 00:12:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:04:44]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1493683889992270,
"parent_rev": "dda54d9447069a3c5dd62fc547ae71f6ff28766e", "commit_rev":
"9146de1595631f543f2388239efba1ed1362704a"}

[commit-bot: I haz the power, 2017-05-02 01:04:57]

Description was changed from

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

BUG=709964
==========

to

==========
Allow to use measured width in translate overflow menu
When showing the overflow menu, we should use measured width (by
setting fixedWidth to false) to make sure all items fit inside the
menu.
When showing the language menu (with 100+ languages), we should use the
hardcoded width (fixedWidth = true) so that it won't take a long time
to measure all item widths.

BUG=709964

Review-Url: https://codereview.chromium.org/2824083003
Cr-Commit-Position: refs/heads/master@{#468518}
Committed:
https://chromium.googlesource.com/chromium/src/+/9146de1595631f543f2388239efb...
==========

[commit-bot: I haz the power, 2017-05-02 01:04:58]

Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/9146de1595631f543f2388239efb...