chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java - Issue 2824083003: Allow to use measured width in translate overflow menu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java

Issue 2824083003: Allow to use measured width in translate overflow menu (Closed)

Patch Set: sync Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenuHelper.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java

index 35230f1a0975e8732b6c3f72cf5cff1fceb4e338..8d805b6bbd295030dfe05a831282cdbda10eb3d8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateMenu.java

@@ -40,9 +40,8 @@ public final class TranslateMenu {

// Menu item type config.

public static final int ITEM_DIVIDER = 0;

public static final int ITEM_LANGUAGE = 1;

- public static final int ITEM_TEXT_OPTION = 2;

- public static final int ITEM_CHECKBOX_OPTION = 3;

- public static final int MENU_ITEM_TYPE_COUNT = 4;

+ public static final int ITEM_CHECKBOX_OPTION = 2;

+ public static final int MENU_ITEM_TYPE_COUNT = 3;

// Menu Item ID config for MENU_OVERFLOW .

public static final int ID_UNDEFINED = 0;

@@ -61,12 +60,13 @@ public final class TranslateMenu {

// Load overflow menu item if it's empty.

synchronized (OVERFLOW_MENU) {

if (OVERFLOW_MENU.isEmpty()) {

- OVERFLOW_MENU.add(new MenuItem(ITEM_TEXT_OPTION, ID_OVERFLOW_MORE_LANGUAGE));

+ OVERFLOW_MENU.add(new MenuItem(ITEM_CHECKBOX_OPTION, ID_OVERFLOW_MORE_LANGUAGE));

OVERFLOW_MENU.add(new MenuItem(ITEM_DIVIDER, ID_UNDEFINED));

OVERFLOW_MENU.add(new MenuItem(ITEM_CHECKBOX_OPTION, ID_OVERFLOW_ALWAYS_TRANSLATE));

- OVERFLOW_MENU.add(new MenuItem(ITEM_TEXT_OPTION, ID_OVERFLOW_NEVER_LANGUAGE));

- OVERFLOW_MENU.add(new MenuItem(ITEM_TEXT_OPTION, ID_OVERFLOW_NEVER_SITE));

- OVERFLOW_MENU.add(new MenuItem(ITEM_TEXT_OPTION, ID_OVERFLOW_NOT_THIS_LANGUAGE));

+ OVERFLOW_MENU.add(new MenuItem(ITEM_CHECKBOX_OPTION, ID_OVERFLOW_NEVER_LANGUAGE));

+ OVERFLOW_MENU.add(new MenuItem(ITEM_CHECKBOX_OPTION, ID_OVERFLOW_NEVER_SITE));

+ OVERFLOW_MENU.add(

+ new MenuItem(ITEM_CHECKBOX_OPTION, ID_OVERFLOW_NOT_THIS_LANGUAGE));

}

return OVERFLOW_MENU;