Compile search_box in gyp v2.

Compile search_box in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823793002
Cr-Commit-Position: refs/heads/master@{#465220}
Committed: https://chromium.googlesource.com/chromium/src/+/13bdf6f4f92e80ed3b23ad8f2418a5d180e732dc

[oka, 2017-04-16 22:57:54]

Description was changed from

==========
Compile search_box in gyp v2.

item.searchQuery -> item['searchQuery'], to avoid error.

BUG=
==========

to

==========
Compile search_box in gyp v2.

item.searchQuery -> item['searchQuery'], to avoid error.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 05:14:17]

Description was changed from

==========
Compile search_box in gyp v2.

item.searchQuery -> item['searchQuery'], to avoid error.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile search_box in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 05:14:33]

.

[oka, 2017-04-17 05:15:05]

Description was changed from

==========
Compile search_box in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile search_box in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 05:15:05]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-17 05:15:33]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org

[oka, 2017-04-17 05:15:33]

PTAL.
dbeam@ for ui/webui/**
fukino@ for others.

[oka, 2017-04-17 05:16:37]

Description was changed from

==========
Compile search_box in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile search_box in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-04-17 07:38:25]

ui/file_manager and file_manager_private.js lgtm with a nit.

https://codereview.chromium.org/2823793002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/search_controller.js (right):

https://codereview.chromium.org/2823793002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/search_controller.js:128: /** @type
{SearchItem} */ {isHeaderItem: true, searchQuery: searchString};
wrap the object by (), like ({isHeaderItem: ....  })

[oka, 2017-04-17 08:31:44]

Addressed comments.

[oka, 2017-04-17 08:33:56]

.

[oka, 2017-04-17 08:34:19]

https://codereview.chromium.org/2823793002/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/search_controller.js (right):

https://codereview.chromium.org/2823793002/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/search_controller.js:128: /** @type
{SearchItem} */ {isHeaderItem: true, searchQuery: searchString};
On 2017/04/17 07:38:25, fukino wrote:
> wrap the object by (), like ({isHeaderItem: ....  })

Done.

[oka, 2017-04-17 08:34:27]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 08:34:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-17 08:34:48]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 08:34:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 09:36:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 09:36:33]

Dry run: This issue passed the CQ dry run.

[oka, 2017-04-18 01:14:33]

dbeam@ Friendly ping?

[Dan Beam, 2017-04-18 01:26:44]

lgtm

[oka, 2017-04-18 12:47:58]

The CQ bit was checked by oka@chromium.org

[oka, 2017-04-18 12:47:59]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2823793002/#ps60001
(title: ".")

[commit-bot: I haz the power, 2017-04-18 12:48:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:54:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492519678926430,
"parent_rev": "d7ee7bd39ec8b1b9d405f05f4ec5c07da5e3a5cd", "commit_rev":
"13bdf6f4f92e80ed3b23ad8f2418a5d180e732dc"}

[commit-bot: I haz the power, 2017-04-18 13:54:43]

Description was changed from

==========
Compile search_box in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile search_box in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823793002
Cr-Commit-Position: refs/heads/master@{#465220}
Committed:
https://chromium.googlesource.com/chromium/src/+/13bdf6f4f92e80ed3b23ad8f2418...
==========

[commit-bot: I haz the power, 2017-04-18 13:54:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/13bdf6f4f92e80ed3b23ad8f2418...