Compile all the UI elements of Files app in gyp v2

Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826433002
Cr-Commit-Position: refs/heads/master@{#465316}
Committed: https://chromium.googlesource.com/chromium/src/+/b3960c81c0209e718309ca0b09f3048653f0dfba

[oka, 2017-04-17 09:29:29]

Description was changed from

==========
Compile all the targets in file_manager/foreground/js/ui.

BUG=636289
TEST=run_compiler
==========

to

==========
Compile all the targets in file_manager/foreground/js/ui.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 09:29:31]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 09:29:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-17 10:11:52]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-17 10:11:52]

PTAL.

[oka, 2017-04-17 10:12:22]

Description was changed from

==========
Compile all the targets in file_manager/foreground/js/ui.

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 10:12:31]

Description was changed from

==========
Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-04-17 10:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 10:37:13]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-04-18 03:46:56]

lgtm with a nit. Thanks!

https://codereview.chromium.org/2826433002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2826433002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/compiled_resources2.gyp:205:
'../../foreground/js/ui/compiled_resources2.gyp:progress_center_panel',
nit: sort

[oka, 2017-04-18 13:28:35]

Addressed comments.

[oka, 2017-04-18 13:29:17]

https://codereview.chromium.org/2826433002/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/background/js/compiled_resources2.gyp (right):

https://codereview.chromium.org/2826433002/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/background/js/compiled_resources2.gyp:205:
'../../foreground/js/ui/compiled_resources2.gyp:progress_center_panel',
On 2017/04/18 03:46:55, fukino wrote:
> nit: sort

Done.

[oka, 2017-04-18 18:40:55]

The CQ bit was checked by oka@chromium.org

[oka, 2017-04-18 18:40:56]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2826433002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-04-18 18:41:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 19:08:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492540855775860,
"parent_rev": "4945caaf823ee78599bf3936bc31963373edc36e", "commit_rev":
"b3960c81c0209e718309ca0b09f3048653f0dfba"}

[commit-bot: I haz the power, 2017-04-18 19:09:43]

Description was changed from

==========
Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile all the UI elements of Files app in gyp v2

BUG=636289
TEST=run_compiler, try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826433002
Cr-Commit-Position: refs/heads/master@{#465316}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3960c81c0209e718309ca0b09f3...
==========

[commit-bot: I haz the power, 2017-04-18 19:09:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b3960c81c0209e718309ca0b09f3...