Compile even more Files app targets in gyp v2.

Compile even more Files app targets in gyp v2.

BUG=636289
TEST=run_compiler,try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819863002
Cr-Commit-Position: refs/heads/master@{#465202}
Committed: https://chromium.googlesource.com/chromium/src/+/1fbd2d9509090898d2155481756a0fbf52986e69

[oka, 2017-04-14 18:10:47]

Description was changed from

==========
Compile event more Files app targets in gyp v2.

BUG=
==========

to

==========
Compile event more Files app targets in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-14 18:12:12]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-14 18:12:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-04-14 18:15:42]

format.

[oka, 2017-04-16 22:21:32]

Description was changed from

==========
Compile event more Files app targets in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile even more Files app targets in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-16 22:25:24]

Description was changed from

==========
Compile even more Files app targets in gyp v2.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile even more Files app targets in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-16 22:25:24]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2017-04-16 22:25:56]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org

[oka, 2017-04-16 22:25:57]

PTAL.
dbeam@ for ui/webui/**
fukino@ for ui/file_manager/**

[oka, 2017-04-16 22:42:24]

.

[oka, 2017-04-16 22:58:33]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-16 22:58:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-16 23:36:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-16 23:36:09]

Dry run: This issue passed the CQ dry run.

[fukino, 2017-04-17 07:33:00]

lgtm with nits

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var
updateEvent = (/** @type {MenuItemUpdateEvent}*/ (new Event('update')));
nit: space after '}'

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var
updateEvent = (/** @type {MenuItemUpdateEvent}*/ (new Event('update')));
nit: the outmost '(' and ')' are not necessary.

[oka, 2017-04-17 08:28:34]

Addressed comments.

[oka, 2017-04-17 08:28:59]

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right):

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var
updateEvent = (/** @type {MenuItemUpdateEvent}*/ (new Event('update')));
On 2017/04/17 07:32:59, fukino wrote:
> nit: the outmost '(' and ')' are not necessary.

Done.

https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var
updateEvent = (/** @type {MenuItemUpdateEvent}*/ (new Event('update')));
On 2017/04/17 07:32:59, fukino wrote:
> nit: space after '}'

Done.

[oka, 2017-04-17 08:35:18]

Description was changed from

==========
Compile even more Files app targets in gyp v2.

BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile even more Files app targets in gyp v2.

BUG=636289
TEST=run_compiler,try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-04-17 08:35:39]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-17 08:36:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-17 09:15:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-17 09:15:20]

Dry run: This issue passed the CQ dry run.

[oka, 2017-04-18 01:14:24]

dbeam@ Friendly ping?

[Dan Beam, 2017-04-18 01:26:08]

lgtm

https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs...
File ui/file_manager/externs/compiled_resources2.gyp (right):

https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs...
ui/file_manager/externs/compiled_resources2.gyp:107: 'target_name':
'menu_item_update_event',
btw,
https://cs.chromium.org/chromium/src/third_party/closure_compiler/tools/creat...
turns a bunch of *.js files in a directory into a file like this

third_party/closure_compiler/tools/create_include_gyp.py
ui/file_manager/externs/ > ui/file_manager/externs/compiled_resources2.gyp

might Just Work?

[oka, 2017-04-18 11:23:28]

On 2017/04/18 01:26:08, Dan Beam wrote:
> lgtm
> 
>
https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs...
> File ui/file_manager/externs/compiled_resources2.gyp (right):
> 
>
https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs...
> ui/file_manager/externs/compiled_resources2.gyp:107: 'target_name':
> 'menu_item_update_event',
> btw,
>
https://cs.chromium.org/chromium/src/third_party/closure_compiler/tools/creat...
> turns a bunch of *.js files in a directory into a file like this
> 
> third_party/closure_compiler/tools/create_include_gyp.py
> ui/file_manager/externs/ > ui/file_manager/externs/compiled_resources2.gyp
> 
> might Just Work?


It didn't work.
third_party/closure_compiler/tools/create_include_gyp.py ui/file_manager/externs
ends up with no found.
third_party/closure_compiler/tools/create_include_gyp.py
../../ui/file_manager/externs
generated ../include_js.gypi as include instead of correct
'../../../third_party/closure_compiler/include_js.gypi'.
<       'includes': ['../../../third_party/closure_compiler/include_js.gypi'],
---
>       'includes': ['../include_js.gypi'],

in_reply_to: 5665117697998848
send_mail: 1
subject: Compile even more Files app targets in gyp v2.

[oka, 2017-04-18 11:24:36]

The CQ bit was checked by oka@chromium.org

[oka, 2017-04-18 11:24:37]

The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2819863002/#ps60001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2017-04-18 11:24:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 12:02:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492514676974020,
"parent_rev": "50cd0d9a646c1d85d271ebde578111874f2b6aa2", "commit_rev":
"1fbd2d9509090898d2155481756a0fbf52986e69"}

[commit-bot: I haz the power, 2017-04-18 12:02:36]

Description was changed from

==========
Compile even more Files app targets in gyp v2.

BUG=636289
TEST=run_compiler,try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile even more Files app targets in gyp v2.

BUG=636289
TEST=run_compiler,try
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2819863002
Cr-Commit-Position: refs/heads/master@{#465202}
Committed:
https://chromium.googlesource.com/chromium/src/+/1fbd2d9509090898d2155481756a...
==========

[commit-bot: I haz the power, 2017-04-18 12:02:38]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1fbd2d9509090898d2155481756a...