Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2819863002: Compile even more Files app targets in gyp v2. (Closed)

Created:
3 years, 8 months ago by oka
Modified:
3 years, 8 months ago
Reviewers:
fukino, Dan Beam
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile even more Files app targets in gyp v2. BUG=636289 TEST=run_compiler,try CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2819863002 Cr-Commit-Position: refs/heads/master@{#465202} Committed: https://chromium.googlesource.com/chromium/src/+/1fbd2d9509090898d2155481756a0fbf52986e69

Patch Set 1 #

Patch Set 2 : format. #

Patch Set 3 : . #

Total comments: 4

Patch Set 4 : Addressed comments. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -15 lines) Patch
M ui/file_manager/externs/compiled_resources2.gyp View 1 chunk +4 lines, -0 lines 1 comment Download
A ui/file_manager/externs/menu_item_update_event.js View 1 chunk +14 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/compiled_resources2.gyp View 3 chunks +45 lines, -12 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/js/cr/ui/compiled_resources2.gyp View 2 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 31 (20 generated)
oka
format.
3 years, 8 months ago (2017-04-14 18:15:42 UTC) #4
oka
PTAL. dbeam@ for ui/webui/** fukino@ for ui/file_manager/**
3 years, 8 months ago (2017-04-16 22:25:57 UTC) #9
oka
.
3 years, 8 months ago (2017-04-16 22:42:24 UTC) #10
fukino
lgtm with nits https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js#newcode991 ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var updateEvent = (/** @type {MenuItemUpdateEvent}*/ ...
3 years, 8 months ago (2017-04-17 07:33:00 UTC) #15
oka
Addressed comments.
3 years, 8 months ago (2017-04-17 08:28:34 UTC) #16
oka
https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js File ui/file_manager/file_manager/foreground/js/ui/directory_tree.js (right): https://codereview.chromium.org/2819863002/diff/40001/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js#newcode991 ui/file_manager/file_manager/foreground/js/ui/directory_tree.js:991: var updateEvent = (/** @type {MenuItemUpdateEvent}*/ (new Event('update'))); On ...
3 years, 8 months ago (2017-04-17 08:28:59 UTC) #17
oka
dbeam@ Friendly ping?
3 years, 8 months ago (2017-04-18 01:14:24 UTC) #23
Dan Beam
lgtm https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs/compiled_resources2.gyp File ui/file_manager/externs/compiled_resources2.gyp (right): https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs/compiled_resources2.gyp#newcode107 ui/file_manager/externs/compiled_resources2.gyp:107: 'target_name': 'menu_item_update_event', btw, https://cs.chromium.org/chromium/src/third_party/closure_compiler/tools/create_include_gyp.py turns a bunch of ...
3 years, 8 months ago (2017-04-18 01:26:08 UTC) #24
oka
On 2017/04/18 01:26:08, Dan Beam wrote: > lgtm > > https://codereview.chromium.org/2819863002/diff/60001/ui/file_manager/externs/compiled_resources2.gyp > File ui/file_manager/externs/compiled_resources2.gyp (right): ...
3 years, 8 months ago (2017-04-18 11:23:28 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2819863002/60001
3 years, 8 months ago (2017-04-18 11:24:53 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 12:02:38 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/1fbd2d9509090898d2155481756a...

Powered by Google App Engine
This is Rietveld 408576698