Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282373004: Remove by-reference implementations of blink::WebMediaPlayer::buffered() (Closed)

Created:
6 years, 7 months ago by sandersd (OOO until July 31)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, avayvod+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove by-reference implementations of blink::WebMediaPlayer::buffered() This cleans up after r270870 following the blink-side changes. BUG=360254 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M content/renderer/media/android/media_source_delegate.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/media/android/media_source_delegate.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sandersd (OOO until July 31)
6 years, 7 months ago (2014-05-16 18:19:12 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 7 months ago (2014-05-16 19:13:23 UTC) #2
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-22 23:09:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/282373004/1
6 years, 7 months ago (2014-05-22 23:10:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 03:01:00 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 06:09:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/31884)
6 years, 7 months ago (2014-05-23 06:09:50 UTC) #7
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 7 months ago (2014-05-23 18:21:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/282373004/1
6 years, 7 months ago (2014-05-23 18:22:51 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 22:58:14 UTC) #10
Message was sent while issue was closed. 
Change committed as 272626

Powered by Google App Engine
This is Rietveld 408576698