Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1866)

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 282373004: Remove by-reference implementations of blink::WebMediaPlayer::buffered() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/webmediaplayer_impl.h ('k') | content/renderer/media/webmediaplayer_ms.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/webmediaplayer_impl.cc
diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc
index 12509dcfbaf0147ae51bebdd84c1f72deba51f4d..6aa009a18f401e9d954f6649fbfd9c073f53c634 100644
--- a/content/renderer/media/webmediaplayer_impl.cc
+++ b/content/renderer/media/webmediaplayer_impl.cc
@@ -511,18 +511,6 @@ WebMediaPlayer::ReadyState WebMediaPlayerImpl::readyState() const {
return ready_state_;
}
-const blink::WebTimeRanges& WebMediaPlayerImpl::buffered() {
- DCHECK(main_loop_->BelongsToCurrentThread());
- media::Ranges<base::TimeDelta> buffered_time_ranges =
- pipeline_.GetBufferedTimeRanges();
- buffered_data_source_host_.AddBufferedTimeRanges(
- &buffered_time_ranges, pipeline_.GetMediaDuration());
- blink::WebTimeRanges buffered_web_time_ranges(
- ConvertToWebTimeRanges(buffered_time_ranges));
- buffered_web_time_ranges_.swap(buffered_web_time_ranges);
- return buffered_web_time_ranges_;
-}
-
blink::WebTimeRanges WebMediaPlayerImpl::buffered() const {
DCHECK(main_loop_->BelongsToCurrentThread());
media::Ranges<base::TimeDelta> buffered_time_ranges =
« no previous file with comments | « content/renderer/media/webmediaplayer_impl.h ('k') | content/renderer/media/webmediaplayer_ms.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698