content/renderer/media/webmediaplayer_impl.h - Issue 282373004: Remove by-reference implementations of blink::WebMediaPlayer::buffered()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.h

Issue 282373004: Remove by-reference implementations of blink::WebMediaPlayer::buffered() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/media/webmediaplayer_impl.h

diff --git a/content/renderer/media/webmediaplayer_impl.h b/content/renderer/media/webmediaplayer_impl.h

index a58613ecea4b5b0aedf154ca9fe6d71de69a5932..c27c0393c429b11adb7e7b19479b21df960b05d1 100644

--- a/content/renderer/media/webmediaplayer_impl.h

+++ b/content/renderer/media/webmediaplayer_impl.h

@@ -87,7 +87,6 @@ class WebMediaPlayerImpl

virtual void setRate(double rate);

virtual void setVolume(double volume);

virtual void setPreload(blink::WebMediaPlayer::Preload preload);

- virtual const blink::WebTimeRanges& buffered();

virtual blink::WebTimeRanges buffered() const;

virtual double maxTimeSeekable() const;

@@ -327,8 +326,6 @@ class WebMediaPlayerImpl

media::ChunkDemuxer* chunk_demuxer_;

BufferedDataSourceHostImpl buffered_data_source_host_;

- // TODO(sandersd): Remove this cache. http://crbug.com/360254

- blink::WebTimeRanges buffered_web_time_ranges_;

// Temporary for EME v0.1. In the future the init data type should be passed

// through GenerateKeyRequest() directly from WebKit.

« no previous file with comments | « content/renderer/media/android/webmediaplayer_android.cc ('k') | content/renderer/media/webmediaplayer_impl.cc » ('j') | no next file with comments »