Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: content/renderer/media/android/webmediaplayer_android.h

Issue 282373004: Remove by-reference implementations of blink::WebMediaPlayer::buffered() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 5 #ifndef CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 6 #define CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 const blink::WebURL& url, 91 const blink::WebURL& url,
92 CORSMode cors_mode); 92 CORSMode cors_mode);
93 93
94 // Playback controls. 94 // Playback controls.
95 virtual void play(); 95 virtual void play();
96 virtual void pause(); 96 virtual void pause();
97 virtual void seek(double seconds); 97 virtual void seek(double seconds);
98 virtual bool supportsSave() const; 98 virtual bool supportsSave() const;
99 virtual void setRate(double rate); 99 virtual void setRate(double rate);
100 virtual void setVolume(double volume); 100 virtual void setVolume(double volume);
101 virtual const blink::WebTimeRanges& buffered();
102 virtual blink::WebTimeRanges buffered() const; 101 virtual blink::WebTimeRanges buffered() const;
103 virtual double maxTimeSeekable() const; 102 virtual double maxTimeSeekable() const;
104 103
105 // Poster image, as defined in the <video> element. 104 // Poster image, as defined in the <video> element.
106 virtual void setPoster(const blink::WebURL& poster) OVERRIDE; 105 virtual void setPoster(const blink::WebURL& poster) OVERRIDE;
107 106
108 // Methods for painting. 107 // Methods for painting.
109 virtual void paint(blink::WebCanvas* canvas, 108 virtual void paint(blink::WebCanvas* canvas,
110 const blink::WebRect& rect, 109 const blink::WebRect& rect,
111 unsigned char alpha); 110 unsigned char alpha);
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
445 444
446 // NOTE: Weak pointers must be invalidated before all other member variables. 445 // NOTE: Weak pointers must be invalidated before all other member variables.
447 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_; 446 base::WeakPtrFactory<WebMediaPlayerAndroid> weak_factory_;
448 447
449 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid); 448 DISALLOW_COPY_AND_ASSIGN(WebMediaPlayerAndroid);
450 }; 449 };
451 450
452 } // namespace content 451 } // namespace content
453 452
454 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_ 453 #endif // CONTENT_RENDERER_MEDIA_ANDROID_WEBMEDIAPLAYER_ANDROID_H_
OLDNEW
« no previous file with comments | « content/renderer/media/android/media_source_delegate.cc ('k') | content/renderer/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698