Deprecate Once-Per-Origin Navigation histograms

Deprecate Once-Per-Origin Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number of page navigations in Incognito mode instead of counting only once-per-origin. This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2823233003
Cr-Commit-Position: refs/heads/master@{#465752}
Committed: https://chromium.googlesource.com/chromium/src/+/847504d1a2c7212f33fece91a85426f091d30f7f

[elawrence, 2017-04-18 22:33:25]

elawrence@chromium.org changed reviewers:
+ felt@chromium.org

[elawrence, 2017-04-18 22:33:25]

Is this what you had in mind?

[felt, 2017-04-18 23:53:58]

Yup, this is what I had in mind. However: could you please put the deprecation
of the old metrics in a different CL? Two CLs for the price of one.

[elawrence, 2017-04-19 16:56:25]

Description was changed from

==========
Add Incognito variants to Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

to

==========
As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.
This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

[elawrence, 2017-04-19 16:56:25]

elawrence@chromium.org changed reviewers:
- felt@chromium.org

[elawrence, 2017-04-19 16:57:58]

Patchset #2 (id:20001) has been deleted

[elawrence, 2017-04-19 17:00:03]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 17:00:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:10:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 17:10:05]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[elawrence, 2017-04-19 17:21:14]

elawrence@chromium.org changed reviewers:
+ davidben@chromium.org, mpearson@chromium.org, rohitrao@chromium.org,
thakis@chromium.org

[elawrence, 2017-04-19 17:21:15]

mpearson@ PTAL at histograms.xml
thakis@   PTAL at chrome/browser/build.gn and chrome/browser/tab_contents/*
rohitrao@ PTAL at ios/*
davidben@ PTAL at components/navigation_metrics

Thanks!

[davidben, 2017-04-19 17:23:35]

Yay less code! components/navigation_metrics lgtm.

[elawrence, 2017-04-19 17:26:39]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 17:27:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 17:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 17:36:32]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[elawrence, 2017-04-19 18:07:13]

The CQ bit was checked by elawrence@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 18:08:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elawrence, 2017-04-19 18:29:13]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-04-19 19:15:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 19:15:39]

Dry run: This issue passed the CQ dry run.

[rohitrao (ping after 24h), 2017-04-19 19:21:21]

ios/ LGTM

[Mark P, 2017-04-19 19:30:54]

histograms.xml lgtm

[Nico, 2017-04-19 20:05:09]

My files lgtm.

[Nico, 2017-04-19 20:05:47]

But: Repeat the "Subject:" line as first line in the "Description:" box.
"Description:" is all that goes into git, so it should be self-contained.

[elawrence, 2017-04-19 21:09:50]

Description was changed from

==========
As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.
This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

to

==========
Deprecate Once-Per-Origin Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.
This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

[elawrence, 2017-04-19 21:10:11]

The CQ bit was checked by elawrence@chromium.org

[elawrence, 2017-04-19 21:10:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/2823233003/#ps80001
(title: "Remove deleted .h from .mm")

[commit-bot: I haz the power, 2017-04-19 21:11:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 21:20:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492636211124850,
"parent_rev": "fed3fc6630e9ea6248153708b7f9a301b98624c4", "commit_rev":
"847504d1a2c7212f33fece91a85426f091d30f7f"}

[commit-bot: I haz the power, 2017-04-19 21:20:45]

Description was changed from

==========
Deprecate Once-Per-Origin Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.
This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*
==========

to

==========
Deprecate Once-Per-Origin Navigation histograms

As a part of scoping changes to behavior, we want to collect the absolute number
of page navigations in Incognito mode instead of counting only once-per-origin.
This CL deprecates the old metrics.

BUG=712843
TEST=components_unittests --gtest_filter=NavigationMetrics*.*

Review-Url: https://codereview.chromium.org/2823233003
Cr-Commit-Position: refs/heads/master@{#465752}
Committed:
https://chromium.googlesource.com/chromium/src/+/847504d1a2c7212f33fece91a854...
==========

[commit-bot: I haz the power, 2017-04-19 21:20:46]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/847504d1a2c7212f33fece91a854...