Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2823233003: Deprecate Once-Per-Origin Navigation histograms (Closed)
Patch Set: Remove deleted .h from .mm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index f6f011d742bfa9577270f0731f6c5b52309244e5..12d1af70971c561c5547940b178d535be5bd5263 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -38,7 +38,6 @@
#include "components/keyed_service/core/service_access_type.h"
#include "components/metrics_services_manager/metrics_services_manager.h"
#include "components/navigation_metrics/navigation_metrics.h"
-#include "components/navigation_metrics/origins_seen_service.h"
#include "components/prefs/pref_service.h"
#include "components/reading_list/core/reading_list_model.h"
#include "components/search_engines/template_url_service.h"
@@ -62,7 +61,6 @@
#include "ios/chrome/browser/history/history_service_factory.h"
#include "ios/chrome/browser/history/top_sites_factory.h"
#include "ios/chrome/browser/infobars/infobar_manager_impl.h"
-#include "ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.h"
#import "ios/chrome/browser/metrics/tab_usage_recorder.h"
#import "ios/chrome/browser/native_app_launcher/native_app_navigation_controller.h"
#import "ios/chrome/browser/passwords/password_controller.h"
@@ -1567,11 +1565,8 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,
[fullScreenController_ disableFullScreen];
}
[self recordInterfaceOrientation];
- navigation_metrics::OriginsSeenService* originsSeenService =
- IOSChromeOriginsSeenServiceFactory::GetForBrowserState(self.browserState);
- bool alreadySeen = originsSeenService->Insert(url::Origin(lastCommittedURL));
navigation_metrics::RecordMainFrameNavigation(
- lastCommittedURL, true, self.browserState->IsOffTheRecord(), alreadySeen);
+ lastCommittedURL, true, self.browserState->IsOffTheRecord());
if (loadSuccess) {
scoped_refptr<net::HttpResponseHeaders> headers =
« no previous file with comments | « ios/chrome/browser/metrics/ios_chrome_origins_seen_service_factory.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698