Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7336)

Unified Diff: chrome/browser/tab_contents/navigation_metrics_recorder.cc

Issue 2823233003: Deprecate Once-Per-Origin Navigation histograms (Closed)
Patch Set: Remove deleted .h from .mm Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/tab_contents/origins_seen_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/navigation_metrics_recorder.cc
diff --git a/chrome/browser/tab_contents/navigation_metrics_recorder.cc b/chrome/browser/tab_contents/navigation_metrics_recorder.cc
index 1152f0b3397eced7ebddf97e461d55700179eb90..cebf02812936fc20df37cf12db7f9e60529357a3 100644
--- a/chrome/browser/tab_contents/navigation_metrics_recorder.cc
+++ b/chrome/browser/tab_contents/navigation_metrics_recorder.cc
@@ -7,9 +7,7 @@
#include "base/metrics/histogram_macros.h"
#include "build/build_config.h"
#include "chrome/browser/browser_process.h"
-#include "chrome/browser/tab_contents/origins_seen_service_factory.h"
#include "components/navigation_metrics/navigation_metrics.h"
-#include "components/navigation_metrics/origins_seen_service.h"
#include "components/rappor/public/rappor_utils.h"
#include "components/rappor/rappor_service_impl.h"
#include "content/public/browser/browser_context.h"
@@ -77,17 +75,12 @@ void NavigationMetricsRecorder::DidFinishNavigation(
return;
content::BrowserContext* context = web_contents()->GetBrowserContext();
- navigation_metrics::OriginsSeenService* service =
- OriginsSeenServiceFactory::GetForBrowserContext(context);
content::NavigationEntry* last_committed_entry =
web_contents()->GetController().GetLastCommittedEntry();
- const url::Origin origin(last_committed_entry->GetVirtualURL());
- bool have_already_seen_origin = service->Insert(origin);
navigation_metrics::RecordMainFrameNavigation(
last_committed_entry->GetVirtualURL(),
- navigation_handle->IsSameDocument(), context->IsOffTheRecord(),
- have_already_seen_origin);
+ navigation_handle->IsSameDocument(), context->IsOffTheRecord());
// Record the domain and registry of the URL that resulted in a navigation to
// a |data:| URL, either by redirects or user clicking a link.
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/tab_contents/origins_seen_service_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698