Introduce TaskRunner::RunsTasksInCurrentSequence()

Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define 
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823103003
Cr-Commit-Position: refs/heads/master@{#470173}
Committed: https://chromium.googlesource.com/chromium/src/+/3322df623f6198576a688561fe22a8786b2e1e1f

[Yeol Park, 2017-04-18 04:40:19]

Description was changed from

==========
Define TaskRunner::RunsTasksInCurrentSequence()

This patch is just define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
==========

to

==========
Define TaskRunner::RunsTasksInCurrentSequence()

This patch is just define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Yeol Park, 2017-04-18 05:12:35]

Description was changed from

==========
Define TaskRunner::RunsTasksInCurrentSequence()

This patch is just define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
This patch is just define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Yeol Park, 2017-04-18 05:12:36]

peary2@gmail.com changed reviewers:
+ achuith@chromium.org, agl@chromium.org, alexmos@chromium.org,
alokp@chromium.org, ben@chromium.org, chcunningham@chromium.org,
enne@chromium.org, eugenebut@chromium.org, fdoray@chromium.org,
gab@chromium.org, garykac@chromium.org, jochen@chromium.org, sadrul@chromium.org

[Yeol Park, 2017-04-18 05:13:07]

PTAL :)

gab@ for base/*
enne@ for cc/*
jochen@ for chrome/*, for components/*
alokp@ for chromecast/*
achuith@ for chromeos/*
alexmos@ for content/*
eugenebut@ for ios/*
chcunningham@ media/*
ben@ for mojo/*, third_party/*
agl@ for net/*
garykac@ for remoting/*
sadrul@ for ui/*

[achuithb, 2017-04-18 05:46:08]

chromeos lgtm

[Yeol Park, 2017-04-18 06:17:04]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 06:17:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 06:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 06:52:01]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yeol Park, 2017-04-18 07:45:05]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 07:45:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 08:20:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 08:20:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jochen (gone - plz use gerrit), 2017-04-18 11:38:38]

lgtm

[Yeol Park, 2017-04-18 13:05:16]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:05:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 13:47:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 13:47:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[gab, 2017-04-18 15:00:33]

Thanks for doing this, comments below

https://codereview.chromium.org/2823103003/diff/40001/base/task_runner.h
File base/task_runner.h (right):

https://codereview.chromium.org/2823103003/diff/40001/base/task_runner.h#newc...
base/task_runner.h:80: // general to use 'true' as a default value.
//
// Drepecated: favor RunsTasksInCurrentSequence().
// TODO(http://crbug.com/665062): mass redirect callers and remove this.

https://codereview.chromium.org/2823103003/diff/40001/base/task_runner.h#newc...
base/task_runner.h:95: //   in parallel.
This last statement isn't true yet (SchedulerParallelTaskRunner and
SequencedWorkerPool::Inner). We'd like it to be but it doesn't need to block
initiating this migration. Replace it with:

// TODO(http://crbug.com/665062): this API doesn't make sense for parallel
TaskRunners. Introduce alternate static APIs for documentation purposes of "this
runs in pool X", have RunsTasksInCurrentSequence() return false for parallel
TaskRunners, and ultimately move this method down to SequencedTaskRunner.

https://codereview.chromium.org/2823103003/diff/40001/base/task_scheduler/sch...
File base/task_scheduler/scheduler_worker_pool_impl.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/base/task_scheduler/sch...
base/task_scheduler/scheduler_worker_pool_impl.cc:115: // that reflects this
behavior more accurately. crbug.com/646905
Remove this TODO.

https://codereview.chromium.org/2823103003/diff/40001/base/threading/sequence...
File base/threading/sequenced_worker_pool.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:359: bool RunsTasksOnCurrentThread()
const;
We should be able to get rid of this one too? No external callers should be
using Inner.

https://codereview.chromium.org/2823103003/diff/40001/base/threading/sequence...
base/threading/sequenced_worker_pool.cc:878: bool
SequencedWorkerPool::Inner::RunsTasksOnCurrentThread() const {
Same with this impl?

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
File base/threading/worker_pool.h (right):

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
base/threading/worker_pool.h:51: static bool RunsTasksInCurrentSequence();
"sequence" isn't a concept of WorkerPool, leave the old call behind (WorkerPool
is being replaced by TaskScheduler anyways and barely has any callers left)

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
File base/threading/worker_pool_posix.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
base/threading/worker_pool_posix.cc:129: bool
WorkerPool::RunsTasksInCurrentSequence() {
// static

above.

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
File base/threading/worker_pool_win.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/base/threading/worker_p...
base/threading/worker_pool_win.cc:78: bool
WorkerPool::RunsTasksInCurrentSequence() {
// static

https://codereview.chromium.org/2823103003/diff/40001/content/browser/dom_sto...
File content/browser/dom_storage/dom_storage_task_runner.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/content/browser/dom_sto...
content/browser/dom_storage/dom_storage_task_runner.cc:29: return true;
We no longer want it to be okay to always return true (except in unittests that
individually decide not to care).

I think this should forward the check to
|primary_sequence_->RunsTasksInCurrentSequence()| per PostDelayedTask() doing
that.

If that doesn't work it should at least return the combination of
|primary_sequence_->RunsTasksInCurrentSequence() ||
commit_sequence_->RunsTasksInCurrentSequence()|

https://codereview.chromium.org/2823103003/diff/40001/mojo/public/cpp/binding...
File mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc (right):

https://codereview.chromium.org/2823103003/diff/40001/mojo/public/cpp/binding...
mojo/public/cpp/bindings/tests/bind_task_runner_unittest.cc:51: bool
RunsTasksOnCurrentThread() const {
Remove this.

https://codereview.chromium.org/2823103003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/WebTaskRunner.h (right):

https://codereview.chromium.org/2823103003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/WebTaskRunner.h:68: // Returns true if the
current thread is a thread on which a task may be run.
Update interface comment.

[Eugene But (OOO till 7-30), 2017-04-18 15:57:06]

ios lgtm

[enne (OOO), 2017-04-18 16:44:50]

cc lgtm

[alokp, 2017-04-18 16:49:02]

lgtm

[chcunningham, 2017-04-18 17:28:13]

media lgtm

I'm confused by the CL description though. You seem to be both defining and
*doing* the rename. CL description makes it sound as if rename will come later.

[sadrul, 2017-04-18 17:38:02]

ui lgtm

[Yeol Park, 2017-04-19 05:35:24]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 05:35:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:34:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:34:46]

Dry run: This issue passed the CQ dry run.

[Yeol Park, 2017-04-19 07:42:26]

Description was changed from

==========
This patch is just define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
This patch is define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

Then make RunsTasksOnCurrentThread() non-virtual and define it
in task_runner.cc in terms of RunsTasksInCurrentSequence().

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Yeol Park, 2017-04-19 08:35:40]

I updated the description. :)

[gab, 2017-04-19 18:37:56]

Re. CL description make it:

"""
Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define 
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().
"""

And update the CL title to match the first line of the description.

Also, please always reply comments ("Done." is sufficient if you merely applied
what was asked).

lg, just a few more nits

https://codereview.chromium.org/2823103003/diff/60001/base/task_runner.h
File base/task_runner.h (right):

https://codereview.chromium.org/2823103003/diff/60001/base/task_runner.h#newc...
base/task_runner.h:94: // TaskRunners, and ultimately move this method down to
SequencedTaskRunner.
Indent last 4 lines by two extra spaces to make it clear they're part of TODO
block.

https://codereview.chromium.org/2823103003/diff/60001/content/browser/dom_sto...
File content/browser/dom_storage/dom_storage_task_runner.cc (right):

https://codereview.chromium.org/2823103003/diff/60001/content/browser/dom_sto...
content/browser/dom_storage/dom_storage_task_runner.cc:28: //return true;
nit: remove this leftover

https://codereview.chromium.org/2823103003/diff/60001/content/browser/dom_sto...
content/browser/dom_storage/dom_storage_task_runner.cc:30:
commit_sequence_->RunsTasksOnCurrentThread();
nit: git cl format? I'd expect this to be indented with 4 spaces?

[alexmos, 2017-04-19 20:34:43]

content/ LGTM once gab@'s comments are addressed.

[Yeol Park, 2017-04-20 02:27:39]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 02:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yeol Park, 2017-04-20 02:31:01]

Description was changed from

==========
This patch is define RunsTasksInCurrentSequence for
rename RunsTasksOnCurrentThread in base/task_runner.h

Then make RunsTasksOnCurrentThread() non-virtual and define it
in task_runner.cc in terms of RunsTasksInCurrentSequence().

It's first step to rename RunsTasksOnCurrentThread
to RunsTasksInCurrentSequence.

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define 
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[commit-bot: I haz the power, 2017-04-20 02:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 02:32:15]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Yeol Park, 2017-04-20 05:36:45]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 05:37:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 06:04:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 06:04:34]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Yeol Park, 2017-04-20 07:25:35]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:25:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 10:17:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 10:17:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yeol Park, 2017-04-20 10:37:34]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 10:37:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 10:44:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 10:44:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yeol Park, 2017-04-20 16:12:41]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 16:13:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 16:22:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 16:22:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yeol Park, 2017-04-21 02:56:58]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 02:57:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 04:59:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 04:59:26]

Dry run: This issue passed the CQ dry run.

[Yeol Park, 2017-04-26 10:03:20]

peary2@gmail.com changed reviewers:
+ asanka@chromium.org, brettw@chromium.org, jam@chromium.org,
jamiewalch@chromium.org
- agl@chromium.org, ben@chromium.org, garykac@chromium.org

[Yeol Park, 2017-04-26 10:03:46]

PTAL :)

asanka@ for net/*
jamiewalch@ for remoting/*
jam@ for mojo/*
brettw@ for third_party/*

[gab, 2017-04-26 14:57:57]

On 2017/04/26 10:03:46, Yeol Park wrote:
> PTAL :)
> 
> asanka@ for net/*
> jamiewalch@ for remoting/*
> jam@ for mojo/*
> brettw@ for third_party/*

As previously mentioned: please reply to my previous comments as "Done." (looks
like you did apply them but the Chromium way is to reply to all comments even
when merely applying what was said).

You should then use "Publish+Mail Comments ('m')" to send those replies.

Thanks,
Gab

[gab, 2017-04-26 15:03:05]

Other than that and the comment below, //base lgtm :)

https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc
File base/task_runner.cc (right):

https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc#ne...
base/task_runner.cc:58: return RunsTasksInCurrentSequence();
Actually, let's move this implementation in the header to let the compiler to
inline this redirection.

[jam, 2017-04-26 15:23:49]

mojo lgtm

[Jamie, 2017-04-26 17:16:34]

remoting/ lgtm

[asanka, 2017-04-26 20:44:20]

/net lgtm

[Yeol Park, 2017-04-27 06:03:22]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 06:03:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 06:07:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 06:07:11]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Yeol Park, 2017-04-27 07:21:23]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 07:21:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 09:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 09:53:42]

Dry run: This issue passed the CQ dry run.

[Yeol Park, 2017-04-27 10:13:13]

gab@
done to apply inline.

Thank you for your information :)
I will always reply to all comments.
(I was ashamed to reply. Because of my humble skill...)


On 2017/04/26 15:03:05, gab wrote:
> Other than that and the comment below, //base lgtm :)
> 
> https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc
> File base/task_runner.cc (right):
> 
>
https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc#ne...
> base/task_runner.cc:58: return RunsTasksInCurrentSequence();
> Actually, let's move this implementation in the header to let the compiler to
> inline this redirection.

[gab, 2017-04-27 14:31:17]

https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc
File base/task_runner.cc (right):

https://codereview.chromium.org/2823103003/diff/140001/base/task_runner.cc#ne...
base/task_runner.cc:58: return RunsTasksInCurrentSequence();
On 2017/04/26 15:03:05, gab wrote:
> Actually, let's move this implementation in the header to let the compiler to
> inline this redirection.

FYI: You want to reply "Done." specifically on the comment itself as I did here
as an example :)

https://codereview.chromium.org/2823103003/diff/180001/base/task_runner.h
File base/task_runner.h (right):

https://codereview.chromium.org/2823103003/diff/180001/base/task_runner.h#new...
base/task_runner.h:77: inline bool RunsTasksOnCurrentThread() const {
Don't need explicit "inline" keyword.

Per spec: "A function defined entirely inside a class/struct/union definition,
whether it's a member function or a non-member friend function, is implicitly an
inline function."

[Yeol Park, 2017-05-08 04:48:52]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 04:49:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 07:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:09:24]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yeol Park, 2017-05-08 08:07:53]

The CQ bit was checked by peary2@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 08:08:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 10:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 10:07:57]

Dry run: This issue passed the CQ dry run.

[Yeol Park, 2017-05-09 03:18:10]

The CQ bit was checked by peary2@gmail.com

[Yeol Park, 2017-05-09 03:18:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
achuith@chromium.org, jochen@chromium.org, eugenebut@chromium.org,
alokp@chromium.org, chcunningham@chromium.org, sadrul@chromium.org,
enne@chromium.org, alexmos@chromium.org, asanka@chromium.org, jam@chromium.org,
gab@chromium.org, jamiewalch@chromium.org
Link to the patchset: https://codereview.chromium.org/2823103003/#ps200001
(title: "rebase & remove inline keyword")

[commit-bot: I haz the power, 2017-05-09 03:20:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 03:55:52]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1494299890923090,
"parent_rev": "8e566f616c9ecf713ce7e1283405adfb756a6915", "commit_rev":
"3322df623f6198576a688561fe22a8786b2e1e1f"}

[commit-bot: I haz the power, 2017-05-09 03:56:02]

Description was changed from

==========
Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define 
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Introduce TaskRunner::RunsTasksInCurrentSequence() to replace
TaskRunner::RunsTasksOnCurrentThread().

Make TaskRunner::RunsTasksOnCurrentThread() non-virtual and define 
it in terms of TaskRunner::RunsTasksInCurrentSequence().

It's the first step to rename RunsTasksOnCurrentThread()
to RunsTasksInCurrentSequence().

BUG=665062
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2823103003
Cr-Commit-Position: refs/heads/master@{#470173}
Committed:
https://chromium.googlesource.com/chromium/src/+/3322df623f6198576a688561fe22...
==========

[commit-bot: I haz the power, 2017-05-09 03:56:07]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/3322df623f6198576a688561fe22...