Introduce TaskRunner::RunsTasksInCurrentSequence()

content/browser/dom_storage/dom_storage_task_runner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/dom_storage/dom_storage_task_runner.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/tracked_objects.h"
 
 namespace content {
 
 // DOMStorageWorkerPoolTaskRunner
 
 DOMStorageWorkerPoolTaskRunner::DOMStorageWorkerPoolTaskRunner(
     scoped_refptr<base::SequencedTaskRunner> primary_sequence,
     scoped_refptr<base::SequencedTaskRunner> commit_sequence)
     : primary_sequence_(std::move(primary_sequence)),
       commit_sequence_(std::move(commit_sequence)) {}
 
 DOMStorageWorkerPoolTaskRunner::~DOMStorageWorkerPoolTaskRunner() = default;
 
-bool DOMStorageWorkerPoolTaskRunner::RunsTasksOnCurrentThread() const {
+bool DOMStorageWorkerPoolTaskRunner::RunsTasksInCurrentSequence() const {
   // It is valid for an implementation to always return true.
   return true;

[gab, 2017/04/18 15:00:33]

We no longer want it to be okay to always return true (except in unittests that
individually decide not to care).

I think this should forward the check to
|primary_sequence_->RunsTasksInCurrentSequence()| per PostDelayedTask() doing
that.

If that doesn't work it should at least return the combination of
|primary_sequence_->RunsTasksInCurrentSequence() ||
commit_sequence_->RunsTasksInCurrentSequence()|

 }
 
 bool DOMStorageWorkerPoolTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
     base::OnceClosure task,
     base::TimeDelta delay) {
   return primary_sequence_->PostDelayedTask(from_here, std::move(task), delay);
 }
 
 bool DOMStorageWorkerPoolTaskRunner::PostShutdownBlockingTask(
@@ skipping 21 matching lines @@
 }
 
 // MockDOMStorageTaskRunner
 
 MockDOMStorageTaskRunner::MockDOMStorageTaskRunner(
     scoped_refptr<base::SequencedTaskRunner> task_runner)
     : task_runner_(std::move(task_runner)) {}
 
 MockDOMStorageTaskRunner::~MockDOMStorageTaskRunner() = default;
 
-bool MockDOMStorageTaskRunner::RunsTasksOnCurrentThread() const {
-  return task_runner_->RunsTasksOnCurrentThread();
+bool MockDOMStorageTaskRunner::RunsTasksInCurrentSequence() const {
+  return task_runner_->RunsTasksInCurrentSequence();
 }
 
 bool MockDOMStorageTaskRunner::PostDelayedTask(
     const tracked_objects::Location& from_here,
     base::OnceClosure task,
     base::TimeDelta delay) {
   return task_runner_->PostTask(from_here, std::move(task));
 }
 
 bool MockDOMStorageTaskRunner::PostShutdownBlockingTask(
@@ skipping 10 matching lines @@
 void MockDOMStorageTaskRunner::AssertIsRunningOnCommitSequence() const {
   DCHECK(RunsTasksOnCurrentThread());
 }
 
 scoped_refptr<base::SequencedTaskRunner>
 MockDOMStorageTaskRunner::GetSequencedTaskRunner(SequenceID sequence_id) {
   return task_runner_;
 }
 
 }  // namespace content