third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc - Issue 2823103003: Introduce TaskRunner::RunsTasksInCurrentSequence()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

Issue 2823103003: Introduce TaskRunner::RunsTasksInCurrentSequence() (Closed)

Patch Set: rebase & remove inline keyword Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h ('k') | third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

diff --git a/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc b/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

index 6333a681ebb1329cbce7225c37c9b2325e2d1d28..5e5d7b7444be62146d1158e0bfb2fc3b3ae05459 100644

--- a/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

+++ b/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc

@@ -186,7 +186,7 @@ void TaskQueueImpl::UnregisterTaskQueue() {

main_thread_only().delayed_work_queue.reset();

}

-bool TaskQueueImpl::RunsTasksOnCurrentThread() const {

+bool TaskQueueImpl::RunsTasksInCurrentSequence() const {

return base::PlatformThread::CurrentId() == thread_id_;

}

@@ -355,7 +355,7 @@ void TaskQueueImpl::PushOntoImmediateIncomingQueueLocked(

// However there's no point posting a DoWork for a blocked queue. NB we can

// only tell if it's disabled from the main thread.

bool queue_is_blocked =

- RunsTasksOnCurrentThread() &&

+ RunsTasksInCurrentSequence() &&

(!IsQueueEnabled() || main_thread_only().current_fence);

any_thread().task_queue_manager->OnQueueHasIncomingImmediateWork(

this, sequence_number, queue_is_blocked);