Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2823073003: Make Use of Value::GetList API

Created:
3 years, 8 months ago by jdoerrie
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Use of Value::GetList API BUG=

Patch Set 1 #

Patch Set 2 : Further Usages #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -95 lines) Patch
M chrome/browser/extensions/menu_manager.cc View 1 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/net/predictor.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/startup_pages_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/protocol_handlers_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/pref_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/sync/driver/about_sync_util.cc View 1 16 chunks +61 lines, -63 lines 0 comments Download

Depends on Patchset:

Issue 2823233002 Patch 1

Messages

Total messages: 8 (8 generated)
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-18 13:55:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823073003/1
3 years, 8 months ago (2017-04-18 13:56:24 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 15:40:07 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 8 months ago (2017-04-18 15:40:08 UTC) #4
jdoerrie
The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-18 17:15:56 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2823073003/20001
3 years, 8 months ago (2017-04-18 17:16:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 18:24:05 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 18:24:05 UTC) #8 
Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698