chrome/browser/ui/webui/options/startup_pages_handler.cc - Issue 2823073003: Make Use of Value::GetList API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/startup_pages_handler.cc

Issue 2823073003: Make Use of Value::GetList API

Patch Set: Further Usages Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/options/startup_pages_handler.cc

diff --git a/chrome/browser/ui/webui/options/startup_pages_handler.cc b/chrome/browser/ui/webui/options/startup_pages_handler.cc

index 738625ddac06f0a6bddcb04f3ab26f2261e71d79..3e28c5049cc7ef1625e9462c1e44b3007516f300 100644

--- a/chrome/browser/ui/webui/options/startup_pages_handler.cc

+++ b/chrome/browser/ui/webui/options/startup_pages_handler.cc

@@ -215,8 +215,8 @@ void StartupPagesHandler::DragDropStartupPage(const base::ListValue* args) {

CHECK(args->GetInteger(0, &to_index));

- const base::ListValue* selected;

- CHECK(args->GetList(1, &selected));

+ const base::ListValue* selected =

+ static_cast<const base::ListValue*>(&args->base::Value::GetList()[1]);

std::vector<int> index_list;

for (size_t i = 0; i < selected->GetSize(); ++i) {