Introduce Value::GetList and Value(ListStorage)

Introduce Value::GetList and Value(ListStorage)

As part of the ongoing effort to move base::Value to value semantics
this change introduces base::Value::GetList accessors that expose the
underlying ListStorage of the ListValue. This builds on top of r463684
which made the necessary modifications to ListStorage. Furthermore this
change deprecates the existing ListValue API in favor of using
std::vector's API directly.

Lastly, constructors taking ListStorage parameters are introduced to be
consistent with already existing constructors as well as making it
convenient to create ListValues from previously existing
std::vector<base::Value>s.

R=brettw@chromium.org
BUG=646113
Review-Url: https://codereview.chromium.org/2823233002
Cr-Commit-Position: refs/heads/master@{#465517}
Committed: https://chromium.googlesource.com/chromium/src/+/2b7d0fcd0261f43efa4592f49238270f500cc39a

[jdoerrie, 2017-04-18 13:54:57]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-18 13:55:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-18 15:44:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-18 15:44:21]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-04-18 20:49:11]

Hi Brett, please review.

[brettw, 2017-04-18 20:51:18]

lgtm

[jdoerrie, 2017-04-19 07:11:01]

The CQ bit was checked by jdoerrie@chromium.org

[commit-bot: I haz the power, 2017-04-19 07:11:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-19 07:15:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1492585861768320, "parent_rev":
"e0ecfbb8e0bb3bdfe2b2bb763cffd0784856bf41", "commit_rev":
"2b7d0fcd0261f43efa4592f49238270f500cc39a"}

[commit-bot: I haz the power, 2017-04-19 07:15:55]

Description was changed from

==========
Introduce Value::GetList and Value(ListStorage)

As part of the ongoing effort to move base::Value to value semantics
this change introduces base::Value::GetList accessors that expose the
underlying ListStorage of the ListValue. This builds on top of r463684
which made the necessary modifications to ListStorage. Furthermore this
change deprecates the existing ListValue API in favor of using
std::vector's API directly.

Lastly, constructors taking ListStorage parameters are introduced to be
consistent with already existing constructors as well as making it
convenient to create ListValues from previously existing
std::vector<base::Value>s.

R=brettw@chromium.org
BUG=646113
==========

to

==========
Introduce Value::GetList and Value(ListStorage)

As part of the ongoing effort to move base::Value to value semantics
this change introduces base::Value::GetList accessors that expose the
underlying ListStorage of the ListValue. This builds on top of r463684
which made the necessary modifications to ListStorage. Furthermore this
change deprecates the existing ListValue API in favor of using
std::vector's API directly.

Lastly, constructors taking ListStorage parameters are introduced to be
consistent with already existing constructors as well as making it
convenient to create ListValues from previously existing
std::vector<base::Value>s.

R=brettw@chromium.org
BUG=646113

Review-Url: https://codereview.chromium.org/2823233002
Cr-Commit-Position: refs/heads/master@{#465517}
Committed:
https://chromium.googlesource.com/chromium/src/+/2b7d0fcd0261f43efa4592f49238...
==========

[commit-bot: I haz the power, 2017-04-19 07:15:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b7d0fcd0261f43efa4592f49238...