Update documentation of extension vs. app types

Update documentation of extension vs. app types. Provide a
link to the document from extension.h

BUG=None

Review-Url: https://codereview.chromium.org/2823033002
Cr-Commit-Position: refs/heads/master@{#467820}
Committed: https://chromium.googlesource.com/chromium/src/+/cabfb95ba20550e4504e518a73874dade479eef9

[ncarter (slow), 2017-04-18 21:12:14]

nick@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[ncarter (slow), 2017-04-18 21:12:15]

Devlin, let me know what you think.

I have the hardest time telling the difference between the different flavors of
app (especially distinguishing between 'packaged' and 'platform'); since these
getters are usually what's called from code that's doing the distinguishing, I
think this is the best place to document the differences.

[Devlin, 2017-04-18 22:37:09]

On 2017/04/18 21:12:15, ncarter wrote:
> Devlin, let me know what you think.
> 
> I have the hardest time telling the difference between the different flavors
of
> app (especially distinguishing between 'packaged' and 'platform'); since these
> getters are usually what's called from code that's doing the distinguishing, I
> think this is the best place to document the differences.

Nice!  Thanks for taking the time to write these. :)

We have a newly-ish added readme that would work well these these comments at
extensions/docs/extension_and_app_types.md; I think going forward, that would be
a better de facto place for these comments (if only because *having* a de facto
place is useful).  Can we synthesize these with those comments, and then add a
comment at the top of all these getters:
// See extensions/docs/extension_and_app_types.md for documentation on these
types.

And then place a similar comment above the Type enum in manifest.h?

[ncarter (slow), 2017-04-24 21:08:03]

On 2017/04/18 22:37:09, Devlin wrote:
> On 2017/04/18 21:12:15, ncarter wrote:
> > Devlin, let me know what you think.
> > 
> > I have the hardest time telling the difference between the different flavors
> of
> > app (especially distinguishing between 'packaged' and 'platform'); since
these
> > getters are usually what's called from code that's doing the distinguishing,
I
> > think this is the best place to document the differences.
> 
> Nice!  Thanks for taking the time to write these. :)
> 
> We have a newly-ish added readme that would work well these these comments at
> extensions/docs/extension_and_app_types.md; I think going forward, that would
be
> a better de facto place for these comments (if only because *having* a de
facto
> place is useful).  Can we synthesize these with those comments, and then add a
> comment at the top of all these getters:
> // See extensions/docs/extension_and_app_types.md for documentation on these
> types.
> 
> And then place a similar comment above the Type enum in manifest.h?

Thanks for the idea, this plan sounds good to me -- I'll make it happen.

[ncarter (slow), 2017-04-26 23:27:51]

PTAL, feel free to suggest more text as you like

[Devlin, 2017-04-27 01:50:31]

lgtm.  I'd probably update the CL description to just say "docs" rather than
extension.h, but up to you.  Thanks for doing this!

https://codereview.chromium.org/2823033002/diff/40001/extensions/docs/extensi...
File extensions/docs/extension_and_app_types.md (right):

https://codereview.chromium.org/2823033002/diff/40001/extensions/docs/extensi...
extensions/docs/extension_and_app_types.md:72: HTML5 features. Other than
metadata in the manifest and an icon, a none of a
nit: s/a none of/none of

[ncarter (slow), 2017-04-27 18:22:18]

Description was changed from

==========
Add comments to extension.h to help distinguish between app and extension
types.

BUG=None
==========

to

==========
Update documentation of extension vs. app types. Provide a
link to the document from extension.h

BUG=None
==========

[ncarter (slow), 2017-04-27 18:27:49]

Done, and updated description

https://codereview.chromium.org/2823033002/diff/40001/extensions/docs/extensi...
File extensions/docs/extension_and_app_types.md (right):

https://codereview.chromium.org/2823033002/diff/40001/extensions/docs/extensi...
extensions/docs/extension_and_app_types.md:72: HTML5 features. Other than
metadata in the manifest and an icon, a none of a
On 2017/04/27 01:50:31, Devlin wrote:
> nit: s/a none of/none of

Done.

[ncarter (slow), 2017-04-27 18:27:52]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2017-04-27 18:27:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2823033002/#ps60001
(title: "Tweak extension.h comments")

[commit-bot: I haz the power, 2017-04-27 18:28:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 18:55:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 18:55:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ncarter (slow), 2017-04-27 22:05:49]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2017-04-27 22:29:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493330749651320,
"parent_rev": "1492075fce7add79a11e13a3c40d55261f4ae89d", "commit_rev":
"cabfb95ba20550e4504e518a73874dade479eef9"}

[commit-bot: I haz the power, 2017-04-28 01:54:20]

Description was changed from

==========
Update documentation of extension vs. app types. Provide a
link to the document from extension.h

BUG=None
==========

to

==========
Update documentation of extension vs. app types. Provide a
link to the document from extension.h

BUG=None

Review-Url: https://codereview.chromium.org/2823033002
Cr-Commit-Position: refs/heads/master@{#467820}
Committed:
https://chromium.googlesource.com/chromium/src/+/cabfb95ba20550e4504e518a7387...
==========

[commit-bot: I haz the power, 2017-04-28 01:54:21]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/cabfb95ba20550e4504e518a7387...