Remove opener URLs from CreateNewWindowParams.

Remove opener URLs from CreateNewWindowParams.

Now that this message is serviced on the UI thread, we can use the
real values there, which are more trustworthy anyway. This fixes
bug 674307.

BUG=466297, 674307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2837683002
Cr-Commit-Position: refs/heads/master@{#466796}
Committed: https://chromium.googlesource.com/chromium/src/+/b374042e98055fbf1a709c451d76ca81679fe988

[ncarter (slow), 2017-04-21 23:11:34]

Description was changed from

==========
Remove opener URLs from CreateNewWindowParams.

Now that this message is serviced on the UI thread, we can use the
real values there, which are more trustworthy anyway. This fixes
bug 674307.

BUG=466297,674307
==========

to

==========
Remove opener URLs from CreateNewWindowParams.

Now that this message is serviced on the UI thread, we can use the
real values there, which are more trustworthy anyway. This fixes
bug 674307.

BUG=466297,674307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2017-04-21 23:12:13]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 23:12:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 23:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:24:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2017-04-21 23:25:00]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 23:25:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2017-04-21 23:28:46]

nick@chromium.org changed reviewers:
+ csharrison@chromium.org

[ncarter (slow), 2017-04-21 23:28:47]

csharrison: FYI (this probably doesn't compile yet, but I'm working on it)

[commit-bot: I haz the power, 2017-04-21 23:36:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 23:36:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Charlie Harrison, 2017-04-22 02:55:21]

On 2017/04/21 23:28:47, ncarter wrote:
> csharrison: FYI (this probably doesn't compile yet, but I'm working on it)

Awesome, looks good. Lmk when it's ready.

[ncarter (slow), 2017-04-24 19:02:12]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 19:03:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 19:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 19:39:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ncarter (slow), 2017-04-24 20:21:56]

The CQ bit was checked by nick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 20:22:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-04-24 20:41:03]

This LGTM, nice cleanup :)

[ncarter (slow), 2017-04-24 20:42:40]

The CQ bit was unchecked by nick@chromium.org

[ncarter (slow), 2017-04-24 20:42:40]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:43:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ncarter (slow), 2017-04-24 20:43:47]

nick@chromium.org changed reviewers:
+ nasko@chromium.org

[ncarter (slow), 2017-04-24 20:43:48]

nasko, please review (both with and without your IPC hat)

[commit-bot: I haz the power, 2017-04-24 20:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 20:54:04]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nasko, 2017-04-24 21:00:24]

Thanks for the cleanup! This is really nice :). LGTM

[ncarter (slow), 2017-04-24 21:23:03]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2017-04-24 21:23:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 22:27:48]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493068983625990,
"parent_rev": "ea7316a0f75c3b69964024ce5bfbf664b96fa8fc", "commit_rev":
"b374042e98055fbf1a709c451d76ca81679fe988"}

[commit-bot: I haz the power, 2017-04-24 22:28:08]

Description was changed from

==========
Remove opener URLs from CreateNewWindowParams.

Now that this message is serviced on the UI thread, we can use the
real values there, which are more trustworthy anyway. This fixes
bug 674307.

BUG=466297,674307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove opener URLs from CreateNewWindowParams.

Now that this message is serviced on the UI thread, we can use the
real values there, which are more trustworthy anyway. This fixes
bug 674307.

BUG=466297,674307
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2837683002
Cr-Commit-Position: refs/heads/master@{#466796}
Committed:
https://chromium.googlesource.com/chromium/src/+/b374042e98055fbf1a709c451d76...
==========

[commit-bot: I haz the power, 2017-04-24 22:28:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b374042e98055fbf1a709c451d76...