Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: extensions/common/extension.h

Issue 2823033002: Update documentation of extension vs. app types (Closed)
Patch Set: Tweak extension.h comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/docs/extension_and_app_types.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension.h
diff --git a/extensions/common/extension.h b/extensions/common/extension.h
index 97c0ca6eb3b0fc09393e71a91de75064b5ac06a5..3ed72183f653ccea0ae86d99c904ceef477915ca 100644
--- a/extensions/common/extension.h
+++ b/extensions/common/extension.h
@@ -324,14 +324,19 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
return (creation_flags_ & WAS_INSTALLED_BY_OEM) != 0;
}
- // Type-related queries.
+ // Type-related queries. These are all mutually exclusive.
+ //
+ // The differences between the types of Extension are documented here:
+ // https://chromium.googlesource.com/chromium/src/+/HEAD/extensions/docs/extension_and_app_types.md
+ bool is_platform_app() const; // aka "V2 app", "V2 packaged app"
+ bool is_hosted_app() const; // Hosted app (or bookmark app)
+ bool is_legacy_packaged_app() const; // aka "V1 packaged app"
+ bool is_extension() const; // Regular browser extension, not an app
+ bool is_shared_module() const; // Shared module
+ bool is_theme() const; // Theme
+
+ // True if this is a platform app, hosted app, or legacy packaged app.
bool is_app() const;
- bool is_platform_app() const;
- bool is_hosted_app() const;
- bool is_legacy_packaged_app() const;
- bool is_extension() const;
- bool is_shared_module() const;
- bool is_theme() const;
void AddWebExtentPattern(const URLPattern& pattern);
const URLPatternSet& web_extent() const { return extent_; }
« no previous file with comments | « no previous file | extensions/docs/extension_and_app_types.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698