Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 282293004: Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest (Closed)

Created:
6 years, 7 months ago by bsalomon
Modified:
6 years, 7 months ago
Reviewers:
humper, robertphillips
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest Committed: http://code.google.com/p/skia/source/detail?r=14809

Patch Set 1 #

Patch Set 2 : update #

Patch Set 3 : ignore tests #

Patch Set 4 : add braces to case #

Total comments: 14

Patch Set 5 : Address comments #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -43 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 3 4 3 chunks +13 lines, -29 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
bsalomon
This fixes a performance regression after Chromium started turning on HQ filtering more often. We ...
6 years, 7 months ago (2014-05-20 15:11:12 UTC) #1
bsalomon
Depends on landing https://codereview.chromium.org/298473002/
6 years, 7 months ago (2014-05-20 15:13:28 UTC) #2
robertphillips
https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp File src/core/SkBitmapProcShader.cpp (right): https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp#newcode430 src/core/SkBitmapProcShader.cpp:430: break; Indent on this '}'? https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp#newcode436 src/core/SkBitmapProcShader.cpp:436: if (GrTextureParams::kNone_FilterMode ...
6 years, 7 months ago (2014-05-20 15:34:50 UTC) #3
bsalomon
https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp File src/core/SkBitmapProcShader.cpp (right): https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp#newcode430 src/core/SkBitmapProcShader.cpp:430: break; On 2014/05/20 15:34:50, robertphillips wrote: > Indent on ...
6 years, 7 months ago (2014-05-20 16:13:06 UTC) #4
humper
On 2014/05/20 16:13:06, bsalomon wrote: > https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp > File src/core/SkBitmapProcShader.cpp (right): > > https://codereview.chromium.org/282293004/diff/60001/src/core/SkBitmapProcShader.cpp#newcode430 > ...
6 years, 7 months ago (2014-05-20 17:06:19 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 7 months ago (2014-05-20 17:39:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/282293004/90001
6 years, 7 months ago (2014-05-20 17:40:17 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:51:16 UTC) #8
Message was sent while issue was closed.
Change committed as 14809

Powered by Google App Engine
This is Rietveld 408576698