Centralize decision about whether to do bicubic filtering, and fallbacks to mip, bilerp, or nearest

src/gpu/effects/GrBicubicEffect.h

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrBicubicTextureEffect_DEFINED
 #define GrBicubicTextureEffect_DEFINED
 
@@ skipping 60 matching lines @@
 
     /**
      * Create a Mitchell filter effect with a texture matrix and a domain.
      */
     static GrEffectRef* Create(GrTexture* tex, const SkMatrix& matrix, const SkRect& domain) {
         AutoEffectUnref effect(SkNEW_ARGS(GrBicubicEffect, (tex, gMitchellCoefficients, matrix,
                                                             domain)));
         return CreateEffectRef(effect);
     }
 
+    /**

[robertphillips, 2014/05/20 15:34:50]

The return value discussion doesn't seem right.
Maybe:
// Returns false if the filterMode has been changed; true otherwise. ?

[bsalomon, 2014/05/20 16:13:06]

Done.

+     * Determines whether the bicubic effect should be used based on the transformation from the
+     * local coords to the device. filterMode will be set to kNearest if true is returned (as no
+     * built-in filtering should be used with the bicubic effect) or the fallback filterMode that
+     * should be used if false is returned.
+     */
+    static bool ShouldUseBicubic(const SkMatrix& localCoordsToDevice,
+                                 GrTextureParams::FilterMode* filterMode);
+
 private:
     GrBicubicEffect(GrTexture*, const SkScalar coefficients[16],
                     const SkMatrix &matrix, const SkShader::TileMode tileModes[2]);
     GrBicubicEffect(GrTexture*, const SkScalar coefficients[16],
                     const SkMatrix &matrix, const SkRect& domain);
     virtual bool onIsEqual(const GrEffect&) const SK_OVERRIDE;
 
     float           fCoefficients[16];
     GrTextureDomain fDomain;
 
     GR_DECLARE_EFFECT_TEST;
 
     static const SkScalar gMitchellCoefficients[16];
 
     typedef GrSingleTextureEffect INHERITED;
 };
 
 #endif